Update voice permissions - #161
Merged
Merged
Conversation
jeremy-rifkin
left a comment
jeremy-rifkin
left a comment
Member
There was a problem hiding this comment.
Thanks for taking the time to do this, one comment
| deny: [Discord.PermissionsBitField.Flags.ViewChannel], | ||
| }, | ||
| [this.wheatley.roles.voice_deputy.id]: { allow: [Discord.PermissionsBitField.Flags.ViewChannel] }, | ||
| ["331876085820030978"]: { allow: [Discord.PermissionsBitField.Flags.ViewChannel] }, // Intermediate |
Member
There was a problem hiding this comment.
Suggested change
| ["331876085820030978"]: { allow: [Discord.PermissionsBitField.Flags.ViewChannel] }, // Intermediate | |
| [this.wheatley.skill_roles.intermediate.id]: { allow: [Discord.PermissionsBitField.Flags.ViewChannel] }, |
etc would be good
Contributor
Author
There was a problem hiding this comment.
I should have noted: reason I didn't do this is because it would conflict with #148, and the plan was that this would not be tied to skill roles in the long run anyways. But could do for now, just wanted to avoid adding new stuff that will need to be changed in the near future.
Member
There was a problem hiding this comment.
Discussed offline, will change so that we don't forget to fix later
jeremy-rifkin
approved these changes
May 14, 2025
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
and move permissions-manager.ts into tccpp module