Improve development experience - #199
Merged
Merged
Conversation
Rinzii
suggested changes
Jan 28, 2026
…d get_channel and get_forum_channel - Fixed c-help-redirect stuff - add option to get_channel and get_forum_channel to optionally also check for channel type
jeremy-rifkin
left a comment
jeremy-rifkin
left a comment
Member
There was a problem hiding this comment.
Hi, thanks for taking the time to contribute to the bot! Some initial comments below
xLuxy
force-pushed
the
improvements
branch
2 times, most recently
from
February 5, 2026 23:45
4db3117 to
21d5eee
Compare
| .set_alias_of("rolepersist add") | ||
| .set_permissions(Discord.PermissionFlagsBits.ModerateMembers) | ||
| .set_description(`${capitalize(role).replace("_", " ")}`) | ||
| .set_description(`${capitalize(role as string).replace("_", " ")}`) |
Contributor
Author
There was a problem hiding this comment.
Because of keyof Wheatley["roles"] above being string | number - i didn't really wanna mess with it - if you have a better approach please let me know.
Member
There was a problem hiding this comment.
I'm confused how keyof Wheatley["roles"] is string | number, and how that changed in this PR 🤔
xLuxy
marked this pull request as ready for review
February 6, 2026 02:10
xLuxy
marked this pull request as draft
February 6, 2026 02:10
xLuxy
marked this pull request as ready for review
February 6, 2026 03:24
jeremy-rifkin
left a comment
jeremy-rifkin
left a comment
Member
There was a problem hiding this comment.
Thanks so much again for taking this on and helping us make the development experience better! Some comments below, I think this is very close to being good to go
…ments # Conflicts: # src/modules/tccpp/components/permissions-manager.ts
jeremy-rifkin
approved these changes
Feb 7, 2026
jeremy-rifkin
left a comment
jeremy-rifkin
left a comment
Member
There was a problem hiding this comment.
LGTM, thanks for taking the time to help us make the dev experience better and thanks for all your patience!
|
jeremy-rifkin
added a commit
that referenced
this pull request
Feb 7, 2026
jeremy-rifkin
added a commit
that referenced
this pull request
Feb 8, 2026
This is part 2 of the work started in #199. The previous work helped move us in the right direction with our reliance on hard-coded ids, this PR updates all components to fetch the channels they use and only refer to channels via a map they hold.
jeremy-rifkin
added a commit
that referenced
this pull request
Feb 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves the development experience by checking for channel and role names while not being in production mode and resolves them with given channel name.