Skip to content

Removed throwing exception for not existing tournament. #265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 11, 2024
Merged

Removed throwing exception for not existing tournament. #265

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 20 additions & 18 deletions ...rvice.Application/EventHandlers/TournamentEventHandlers/TournamentCanceledEventHandler.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,29 +35,31 @@ public async Task Handle(DomainEnvelope<IDomainEvent> domainEnvelope)
var tennisClubReadModel =
await tennisClubReadModelRepository.GetTennisClubById(tournamentReadModel.TennisClubId);

if (tennisClubReadModel == null)
if (tennisClubReadModel != null)
{
loggerService.LogTennisClubNotFound(tournamentReadModel.TennisClubId);
throw new TennisClubNotFoundException(domainEnvelope.EntityId);
}

await tournamentReadModelRepository.Delete(tournamentReadModel);
var members = await memberReadModelRepository.GetMembersByTennisClubId(tennisClubReadModel.TennisClubId.Id);
var mailSubject = $"Tournament {tournamentReadModel.Name} canceled";
var mailBody = $"""
Unfortunately the tournament '{tournamentReadModel.Name}' that would have been taking
place from the {tournamentReadModel.StartDate} to the {tournamentReadModel.EndDate} has
been canceled.
""";

var members = await memberReadModelRepository.GetMembersByTennisClubId(tennisClubReadModel.TennisClubId.Id);
var mailSubject = $"Tournament {tournamentReadModel.Name} canceled";
var mailBody = $"""
Unfortunately the tournament '{tournamentReadModel.Name}' that would have been taking
place from the {tournamentReadModel.StartDate} to the {tournamentReadModel.EndDate} has
been canceled.
""";

foreach (var member in members)
foreach (var member in members)
{
var emailMessage = new EmailMessage(Guid.NewGuid(), member.Email, mailSubject, mailBody,
DateTime.UtcNow);
await emailOutboxRepository.Add(emailMessage);
}
}
else
{
var emailMessage = new EmailMessage(Guid.NewGuid(), member.Email, mailSubject, mailBody,
DateTime.UtcNow);
await emailOutboxRepository.Add(emailMessage);
// We can't throw an exception here because deleting a tennis club triggers
// that all associated tournaments are deleted.
loggerService.LogTennisClubNotFound(tournamentReadModel.TennisClubId);
}

await tournamentReadModelRepository.Delete(tournamentReadModel);
loggerService.LogTournamentCanceled(tournamentReadModel.TournamentId);
}

Expand Down
Loading