Skip to content

Projection extension #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 22 commits into from
Jun 7, 2024
Merged

Projection extension #16

merged 22 commits into from
Jun 7, 2024

Conversation

CengoleFHV
Copy link
Contributor

@CengoleFHV CengoleFHV commented Jun 7, 2024 •
edited
Loading

fucking finally :|

 /$$$$$$$$               /$$                                        
| $$_____/              | $$                                        
| $$   /$$   /$$ /$$$$$$| $$   /$$                                  
| $$$$| $$  | $$/$$_____| $$  /$$/                                  
| $$__| $$  | $| $$     | $$$$$$/                                   
| $$  | $$  | $| $$     | $$_  $$                                   
| $$  |  $$$$$$|  $$$$$$| $$ \  $$                                  
|__/   \______/ \_______|__/  \__/                                  
                                                                    
                                                                    
                                                                    
 /$$      /$$/$$                                                    
| $$$    /$$|__/                                                    
| $$$$  /$$$$/$$ /$$$$$$$ /$$$$$$  /$$$$$$                          
| $$ $$/$$ $| $$/$$_____//$$__  $$/$$__  $$/$$$$$$                  
| $$  $$$| $| $| $$     | $$  \__| $$  \ $|______/                  
| $$\  $ | $| $| $$     | $$     | $$  | $$                         
| $$ \/  | $| $|  $$$$$$| $$     |  $$$$$$/                         
|__/     |__|__/\_______|__/      \______/                          
                                                                    
                                                                    
                                                                    
                                      /$$                           
                                     |__/                           
  /$$$$$$$ /$$$$$$  /$$$$$$ /$$    /$$/$$ /$$$$$$$ /$$$$$$  /$$$$$$$
 /$$_____//$$__  $$/$$__  $|  $$  /$$| $$/$$_____//$$__  $$/$$_____/
|  $$$$$$| $$$$$$$| $$  \__/\  $$/$$/| $| $$     | $$$$$$$|  $$$$$$ 
 \____  $| $$_____| $$       \  $$$/ | $| $$     | $$_____/\____  $$
 /$$$$$$$|  $$$$$$| $$        \  $/  | $|  $$$$$$|  $$$$$$$/$$$$$$$/
|_______/ \_______|__/         \_/   |__/\_______/\_______|_______/

CengoleFHV added 17 commits June 5, 2024 01:17
@CengoleFHV
added properties to Member
cedba45
@CengoleFHV
added properties to Member
abedb21
@CengoleFHV
expanded Member props and added MEMBER_UPDATED Event
ad9fd81
@CengoleFHV
Merge remote-tracking branch 'origin/projection_extension' into proje…
7394b9e 
…ction_extension

# Conflicts:
#	Domain/Models/Member.cs
@CengoleFHV
changed fom updatedEvent to Email and FullName Event
5497c10
@CengoleFHV
added properties to Member
93bff8c
@CengoleFHV
expanded Member props and added MEMBER_UPDATED Event
e0bc0f3
@CengoleFHV
changed fom updatedEvent to Email and FullName Event
eaba781
@CengoleFHV
Merge branch 'projection_extension' of https://github.com/THC-Softwar…
f4a0375 
…e/PlayOfferService into projection_extension
@CengoleFHV
added Club Name Changed Event
9baa887
@CengoleFHV
added properties to Member
7c68828
@CengoleFHV
expanded Member props and added MEMBER_UPDATED Event
9e41f2e
@CengoleFHV
changed fom updatedEvent to Email and FullName Event
5d29c3e
@CengoleFHV
expanded Member props and added MEMBER_UPDATED Event
1f04ba9
@CengoleFHV
changed fom updatedEvent to Email and FullName Event
107660c
@CengoleFHV
added Club Name Changed Event
b0d6332
@CengoleFHV
Merge branch 'projection_extension' of https://github.com/THC-Softwar…
a71eb09 
…e/PlayOfferService into projection_extension
@CengoleFHV CengoleFHV requested a review from lolgame99 June 7, 2024 10:49
lolgame99
lolgame99 requested changes Jun 7, 2024
View reviewed changes
Copy link
Contributor

@lolgame99 lolgame99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Folgende Implementierung fehlt:

  • ClubEventHandler -> ClubNameChangedEvent ergänzen (Existierender Club mit Id aus Event laden und event applyen)
  • MemberEventHandler -> MemberEmailChangedEvent & MemberFullNameChangedEvent ergänzen (Existierender Member mit Id aus Event laden und event applyen)

CengoleFHV

This comment was marked as duplicate.

Sign in to view

CengoleFHV
CengoleFHV commented Jun 7, 2024
View reviewed changes
Copy link
Contributor Author

@CengoleFHV CengoleFHV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added changes

lolgame99
lolgame99 approved these changes Jun 7, 2024
View reviewed changes
Copy link
Contributor

@lolgame99 lolgame99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@lolgame99 lolgame99 merged commit a443b49 into dev Jun 7, 2024
1 check passed
@lolgame99 lolgame99 deleted the projection_extension branch June 15, 2024 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lolgame99 lolgame99 lolgame99 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CengoleFHV @lolgame99