Skip to content

Query refactoring #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 17, 2024
Merged

Query refactoring #17

merged 7 commits into from
Jun 17, 2024

Conversation

lolgame99
Copy link
Contributor

  • Split Existing GET Endpoint into 2 seperate Endpoints:
    • GetPlayOffersByClubId
    • GetPlayOffersByParticipantId --> Gets PlayOffers where given MemberId is either creator or opponent
  • Added GET Endpoint to search playoffers by creator name
    • Searches Member by likeness on first and last name
    • Expects query param to have format of <firstName> <lastName>, <firstName>, or <lastName>,
  • Added DTOs for entities containing nested DTOs
  • Refactored all GET Endpoints to return PlayOfferDTO(s)
    • Return value contains all information regarding to playoffer --> club, member, reservation and court details

@lolgame99 lolgame99 requested a review from CengoleFHV June 17, 2024 10:20
Copy link
Contributor

@CengoleFHV CengoleFHV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@CengoleFHV CengoleFHV merged commit e9a9703 into dev Jun 17, 2024
1 check passed
@CengoleFHV CengoleFHV deleted the query_refactoring branch June 17, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants