Skip to content

Reservation saga bugfixes #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 1, 2024
Merged

Reservation saga bugfixes #22

merged 2 commits into from
Jul 1, 2024

Conversation

lolgame99
Copy link
Contributor

Fixed bugs related to PlayOfferJoined --> Reservation Saga:

  • Commited transaction on PlayOfferJoin Command
  • Fixed JsonNameProperty on ReservationCreatedEvent
  • Fixed naming of ReservationLimitExceededEvent
  • Added parsing of correlationId when reading from redis stream
  • Fixed parsing of null values in eventData when reading from redis stream

@lolgame99 lolgame99 requested a review from CengoleFHV July 1, 2024 09:26
CengoleFHV
CengoleFHV approved these changes Jul 1, 2024
View reviewed changes
Copy link
Contributor

@CengoleFHV CengoleFHV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey, thats pretty good

@CengoleFHV CengoleFHV merged commit fa4f9ba into master Jul 1, 2024
1 check passed
@lolgame99 lolgame99 deleted the reservation_saga_bugfixes branch July 9, 2024 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CengoleFHV CengoleFHV CengoleFHV approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lolgame99 @CengoleFHV