Fix classroom generation language normalization for non-English locales#176
Open
GRIZZZZZLY wants to merge 5 commits intoTHU-MAIC:mainfrom
Open
Fix classroom generation language normalization for non-English locales#176GRIZZZZZLY wants to merge 5 commits intoTHU-MAIC:mainfrom
GRIZZZZZLY wants to merge 5 commits intoTHU-MAIC:mainfrom
Conversation
Author
|
Hi! I fixed the formatting issue that previously caused CI to fail on this PR.\n\nThe latest workflow run now shows |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a language handling bug in classroom generation where any non-English language could be coerced to
zh-CN.Problem
The generation pipeline treated
en-USas a special case and defaulted other languages to Chinese. That caused incorrect output language behavior for languages like Russian.Changes
ru-RUzh-CNanden-USare valid generation languagesWhy this matters
This fixes a real generation bug and improves the multilingual architecture of the generation pipeline.
Notes
This PR focuses on generation correctness, not full UI localization.