fix: pass providerType to chat api#206
Closed
ChaseAfterLight wants to merge 1 commit intoTHU-MAIC:mainfrom
Closed
Conversation
Contributor
|
Thanks for the fix! This is covered by #114 which also threads providerType through all three call sites and refactors the chat route to use the shared resolveModel() helper. Closing as duplicate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes chat requests for custom providers by passing
providerTypefrom the client to/api/chatand through server model resolution.Related Issues
None.
Changes
providerTypeto the stateless chat request type.providerTypefromuse-chat-sessionswhen sending chat requests.providerTypeintogetModel()in/api/chat.Unknown provider ... Please provide providerType.Type of Change
Verification
Steps to reproduce / test
Unknown provider ... Please provide providerType.What you personally verified
/api/chatrequests now includesproviderType.pnpm exec tsc --noEmitsuccessfully.Evidence
pnpm check && pnpm lint && npx tsc --noEmit)Checklist