[refactor] Restructure generation services and etc. #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Move generation directory to `api/python` for better code organization - Refactor image generation service to reuse Python API - Clean up .env.template by removing unused properties and fixing typos - Refactor generation_mode to fetch inference tasks directly from pipeline - Add unload_lora_checkpoint logic - Add offload mode selection in API and `before_generation` - Add docs for python API function signature - Fix lora merge logic
OleehyO
force-pushed
the
dev-lhy
branch
3 times, most recently
from
9a502ab to
d156207
Compare
…video`, add lora operations to Python API - Modified `src/cogkit/__init__.py` to updated Python API - Updated `src/cogkit/api/python/generation/(image,video).py` to remove lora param and integrate lora operations - Adjusted `src/cogkit/cli/inference.py` to align with API changes
zhangch9
reviewed
Mar 26, 2025
src/cogkit/cli/inference.py
Outdated
| task = guess_generation_mode(model_id_or_path, task, image_file, video_file) | ||
| dtype = cast_to_torch_dtype(dtype) | ||
| pipeline = load_pipeline(model_id_or_path, transformer_path, dtype) | ||
| task = guess_generation_mode(pipeline=pipeline, image_file=image_file) |
Collaborator
There was a problem hiding this comment.
incorrect type: image_file. See the definition of the function guess_generation_mode.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
api/pythonfor better code organizationguess_generation_modeto fetch inference tasks directly from pipelineunload_lora_checkpointlogicbefore_generation