Refactor and add timers in training#632
Merged
zhuzilin merged 4 commits intoTHUDM:mainfrom Oct 30, 2025
Merged
Conversation
zhuzilin
reviewed
Oct 30, 2025
| self.add(name, elapsed_time) | ||
| del self.start_time[name] | ||
| if torch.distributed.get_rank() == 0: | ||
| print(f"Timer {name} end (elapsed: {elapsed_time:.1f}s)") |
Contributor
There was a problem hiding this comment.
could you remove those 2 prints? I'm afraid this will cause too much print in the log.
Collaborator
Author
There was a problem hiding this comment.
I personally find it pretty useful since it "splits" the log into sections, and this only introduce ~10 lines of log while one step may have ~100 (or ~1000) lines of log from sglang rollout, but if you like I can remove it
llltttwww
pushed a commit
to llltttwww/slime
that referenced
this pull request
Nov 30, 2025
Co-authored-by: Zilin Zhu <zhuzilinallen@gmail.com>
Yangruipis
pushed a commit
to rednote-ai/slime
that referenced
this pull request
Feb 28, 2026
Co-authored-by: Zilin Zhu <zhuzilinallen@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.