Internationalisation, many settings, and other improvements#153
Open
nuest wants to merge 22 commits into
Open
Conversation
nuest
changed the title
…closes TIBHannover#88) Extend the test data for geo.region editing and improve the progress reporting and add manual triggering for the retrieval of metadata suggestions from the gazzetteer multiple fixes for test cases and test setup
…TIBHannover#23 partial implementation of TIBHannover#23 also fixes some tests that are only related
nuest
changed the title
…TIBHannover#112 also some unrelated test fixes
…IBHannover#60 Rewrites write/read/display so geometries that cross the 180° meridian are RFC 7946 §3.1.9 compliant, meta-tag-correct, and visually contiguous. Write: new AntimeridianSplitter (classes/Geo/AntimeridianSplitter.inc.php) runs on the Publication::edit hook; a crossing Polygon / LineString is rewritten as a single MultiPolygon / MultiLineString feature with one part per hemisphere. Idempotent on already-split input. Centroid: antimeridian-aware envelope in bboxFromGeoJson (widest-gap heuristic), crossing-aware mid-longitude in fromBbox, and PDOEngine's Cartesian ST_Envelope is skipped for crossing geometries so ICBM / geo.position tags are no longer biased toward Greenwich. DC.box / ISO 19139 emission is unchanged — east<west is a valid crossing. JS: shared helpers in _map_js_globals.tpl (geoMetadata_normalizeLng, splitLegacyPolygonForDisplay, unwrapForDisplay, prepareFeaturesForDisplay). On write, each .lng read in submission.js is wrapped through normalizeLng so Leaflet's post-drag out-of-range lngs are stored in (-180, 180]. On read, legacy unsplit records are rewritten in-memory so the map still fits them correctly, and split MultiPolygon / MultiLineString features have their negative longitudes unwrapped by +360 for display so the two halves render as one continuous shape across the dateline instead of two disconnected pieces at opposite edges of the world map. Admin-unit overlay: inline bboxToLeafletLayers helper in submission.js and article_details.js emits two rectangles and an unwrapped fitBounds when the GeoNames bbox has east<west (Russia, NZ, Fiji, parts of the US). Deletes the "// TODO handle crossing dateline" marker. UX: worldCopyJump:true on all four Leaflet maps; a small muted note below the editing maps explains the split-on-save behaviour in en_US, de_DE, fr_FR, es_ES (messages.mo regenerated).
Collaborator
Author
|
@tomniers It would be great if you can take a look at this, no time pressure at all. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see related issues in the commits below, should close Milestone https://github.com/TIBHannover/geoMetadata/milestone/7
js/lib/temporal.jsis forward-compat for multi-period)