fix(prorl): green up CI after #251 (pyright typing + Windows bash skip) - #252
Merged
Conversation
#251 merged with two CI failures from the new prorl tests (ubuntu/macos passed): - static-check (pyright on tests/): _minimal_request built a heterogeneous dict so pyright inferred a union for **kwargs. Annotate kwargs: dict[str, Any]. - pytest (windows-latest): test_prorl_mock shells out to bash to run the harbor evaluator's POSIX test.sh; Windows has no bash. Skip the module on win32 (ClawBench's runtime is Linux containers by design). Verified: uv run --frozen pyright src/clawbench tests -> 0 errors; ruff clean; pytest -> 110 passed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restores green CI on main after #251. Two failures from the new prorl tests (ubuntu/macos already passed):
test_prorl_models._minimal_requestbuilt a heterogeneousdict→ pyright inferred a union for**kwargs. Annotatedkwargs: dict[str, Any].test_prorl_mockshells out tobashto run the harbor evaluator's POSIXtest.sh; Windows has no bash. Skip the module on win32 (ClawBench runtime is Linux containers by design).Verified locally:
pyright src/clawbench tests0 errors, ruff clean,pytest110 passed.