Fixes an x11vnc startup crash when running clawbench-run with --human. - #279
Merged
Perry2004 merged 1 commit intoAug 8, 2026
Merged
Conversation
Contributor
Author
|
on running only uv run clawbench-run test-cases/v1-lite/002-daily-life-food-doordash --human i have to first open the bash of docker then manually start the x11vnc because of this |
Perry2004
self-requested a review
August 5, 2026 15:34
Collaborator
|
Thanks for the PR! I'll take a look. |
Perry2004
approved these changes
Aug 8, 2026
Collaborator
|
Thanks for the PR. The human mode issue was introduced in my previous browserbase integration and I missed testing human mode. Thanks for the fix I'll merge it into main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
In
src/clawbench/runtime/harnesses/base/entrypoint.sh, the$VNC_GONE_HOOKand$VNC_ACCEPT_HOOKvariables contained unquoted multi-token arguments (-gone touch /data/.vnc-disconnected). Upon shell parameter expansion,x11vncreceived/data/.vnc-disconnectedas an invalid command-line flag, causingx11vncto fail to start.Separated
HUMAN_MODE=1x11vncexecution block and quoted-goneand-afteracceptparameters sox11vncparses them as single string commands.Corpus
Test plan
Tested using:
uv run clawbench-run test-cases/v1-lite/002-daily-life-food-doordash --humanVerified that
x11vnclaunches on port 5900 and noVNC connects smoothly without manual intervention.Related issues
N/A