Skip to content

Fixes an x11vnc startup crash when running clawbench-run with --human. - #279

Merged
Perry2004 merged 1 commit into
TIGER-AI-Lab:mainfrom
ramanbansal1:fix/x11vnc-human-mode-quoting
Aug 8, 2026
Merged

Fixes an x11vnc startup crash when running clawbench-run with --human.#279
Perry2004 merged 1 commit into
TIGER-AI-Lab:mainfrom
ramanbansal1:fix/x11vnc-human-mode-quoting

Conversation

@ramanbansal1

Copy link
Copy Markdown
Contributor

What does this PR do?

In src/clawbench/runtime/harnesses/base/entrypoint.sh, the $VNC_GONE_HOOK and $VNC_ACCEPT_HOOK variables contained unquoted multi-token arguments (-gone touch /data/.vnc-disconnected). Upon shell parameter expansion, x11vnc received /data/.vnc-disconnected as an invalid command-line flag, causing x11vnc to fail to start.

Separated HUMAN_MODE=1 x11vnc execution block and quoted -gone and -afteraccept parameters so x11vnc parses them as single string commands.

Corpus

  • v2
  • v1
  • both
  • not applicable

Test plan

Tested using:
uv run clawbench-run test-cases/v1-lite/002-daily-life-food-doordash --human
Verified that x11vnc launches on port 5900 and noVNC connects smoothly without manual intervention.

Related issues

N/A

@ramanbansal1

Copy link
Copy Markdown
Contributor Author

on running only uv run clawbench-run test-cases/v1-lite/002-daily-life-food-doordash --human i have to first open the bash of docker then manually start the x11vnc because of this

@Perry2004
Perry2004 self-requested a review August 5, 2026 15:34
@Perry2004

Copy link
Copy Markdown
Collaborator

Thanks for the PR! I'll take a look.

@Perry2004

Copy link
Copy Markdown
Collaborator

Thanks for the PR. The human mode issue was introduced in my previous browserbase integration and I missed testing human mode.

Thanks for the fix I'll merge it into main.

@Perry2004
Perry2004 merged commit 723974b into TIGER-AI-Lab:main Aug 8, 2026
17 checks passed
@github-project-automation github-project-automation Bot moved this from Todo to Done in ClawBench Aug 8, 2026
@Perry2004 Perry2004 added bug Something isn't working good first issue Good for newcomers labels Aug 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working good first issue Good for newcomers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants