635 Add support for parameterized activity to the uml2cif translators by darets97 · Pull Request #637 · TNO/SynthML

darets97 · 2025-11-12T12:48:14Z

This PR works towards #635.

The all lower case folder names for tests were inspired by petrify2uml
The TemplateParameterFlattener is a simpler implementation of the CompositeDataTypeFlattener. The regression tests happen in the activity flattener since flattening call behaviors happens during activity flattening and can hardly be taken separately in a full transformation.
To prevent templated activities from containing references to template parameters that cannot be represented down the synthesis chain all templated activities are removed after the flattening process.

dhendriks · 2025-11-14T13:42:23Z

I've marked this as WIP. It is not done yet.

darets97 · 2025-11-17T16:07:54Z

Ready for review

...yoke.transform.flatten/src/com/github/tno/pokayoke/transform/flatten/FlattenUMLActivity.java

...nsform.flatten/src/com/github/tno/pokayoke/transform/flatten/TemplateParameterFlattener.java

...ke.transform.uml2cif/src/com/github/tno/pokayoke/transform/uml2cif/ModelToCifTranslator.java

...nsform.flatten/src/com/github/tno/pokayoke/transform/flatten/TemplateParameterFlattener.java

AndreaPuffo · 2025-11-18T13:20:50Z

...nsform.flatten/src/com/github/tno/pokayoke/transform/flatten/TemplateParameterFlattener.java

+import com.google.common.base.Verify;
+
+/** Template parameter flattener. */
+public class TemplateParameterFlattener {


Since I see quite a big overlap with CompositeDataTypeFlattener, I wonder if we should have some more structure between these two files. Maybe having a Flattener class, that includes activities, composite data types, and templates. Perhaps to be discussed with Dennis Hendriks and/or Wytse.

The similarity is largely by design; The two classes traverse the parse trees in a very similar manner. Ordinarily I'd argue we should use the CifObjectWalker or CifObjectVisitor (or I misunderstood the purpose of the Flattener?). In my opinion we should look into improving those classes to simplify manipulating the parse tree, right now using those two classes for generic traversal adds complexity rather than reduce it.

...yoke.transform.flatten/src/com/github/tno/pokayoke/transform/flatten/FlattenUMLActivity.java

...nsform.flatten/src/com/github/tno/pokayoke/transform/flatten/TemplateParameterFlattener.java

...yoke.transform.flatten/src/com/github/tno/pokayoke/transform/flatten/FlattenUMLActivity.java

AndreaPuffo · 2025-11-18T13:41:58Z

I couldn't easily parse the new regression tests. Can you please past here a couple of pictures of the activity diagrams before/after of the new template flattener tests?

Co-authored-by: AndreaPuffo <46629578+AndreaPuffo@users.noreply.github.com>

darets97 · 2025-11-18T19:27:04Z

Ready for next review. All comments should be resolved, but I've opted to leave them open to make the discussion easier to see.

AndreaPuffo · 2025-11-21T07:29:26Z

Looks good to me. Maybe also @dhendriks wants to have a look.

dhendriks · 2025-11-21T10:22:26Z

It's on my list to take a look.

dhendriks · 2025-11-27T14:17:50Z

...yoke.transform.uml2cif/src/com/github/tno/pokayoke/transform/uml2cif/UmlToCifTranslator.java

-        if (context.hasParameterizedActivities()) {
-            throw new RuntimeException("Translating parameterized activities to CIF is unsupported.");
-        }


I'd restore this check, after the conditional call to the flattener. If we flatten, there should be no parameterized activities left. If we don't, there should also not be any (already flattened before). It then states the invariant as a sanity check.

dhendriks · 2025-11-27T14:18:14Z

...yoke.transform.flatten/src/com/github/tno/pokayoke/transform/flatten/FlattenUMLActivity.java

@@ -72,9 +81,21 @@ private void transform(Element element) {
        if (element instanceof Activity activityElement) {


transform/destroyParameterizedActivities: I dislike the 'activityElement' etc names. It sounds like they are elements of an activity, while it is the activity itself. So, name them 'activity', 'class' (or rather 'cls' to prevent using Java keyword), etc.

dhendriks · 2025-11-27T14:18:52Z

...yoke.transform.flatten/src/com/github/tno/pokayoke/transform/flatten/FlattenUMLActivity.java

                // considered leaves, as are call behavior actions that call opaque behaviors.
-                if (behavior instanceof Activity activity && action.getAppliedStereotypes().isEmpty()) {
+                if (behavior instanceof Activity activity && action.getAppliedStereotypes().stream()
+                        .filter(s -> !PokaYokeUmlProfileUtil.FORMAL_CALL_BEHAVIOR_ACTION_STEREOTYPE


This checks if no stereotype other than the formal call behavior action stereotype is present. It should instead check for that stereotype not being present, right? So, remove the ! operator? How come this works now, and the tests don't show this issue?

dhendriks · 2025-11-27T14:20:43Z

...yoke.transform.flatten/src/com/github/tno/pokayoke/transform/flatten/FlattenUMLActivity.java

                // considered leaves, as are call behavior actions that call opaque behaviors.
-                if (behavior instanceof Activity activity && action.getAppliedStereotypes().isEmpty()) {
+                if (behavior instanceof Activity activity && action.getAppliedStereotypes().stream()
+                        .filter(s -> !PokaYokeUmlProfileUtil.FORMAL_CALL_BEHAVIOR_ACTION_STEREOTYPE


Can't we add a method like PokaYokeUmlProfileUtil.isFormalElement to check for this, rather than doing the name check?

dhendriks · 2025-11-27T14:21:47Z

...nsform.flatten/src/com/github/tno/pokayoke/transform/flatten/TemplateParameterFlattener.java

+                    AExpression unfoldedOutgoing = unfoldAExpression(outgoingGuard, nameToArgument);
+                    PokaYokeUmlProfileUtil.setOutgoingGuard(controlEdge, ACifObjectToString.toString(unfoldedOutgoing));
+                }
+            } else if (ownedElement instanceof CallBehaviorAction callBehavior) {


Assert that the call behavior has no arguments, as then something is wrong in the flattening order?

dhendriks · 2025-11-27T14:22:11Z

...nsform.flatten/src/com/github/tno/pokayoke/transform/flatten/TemplateParameterFlattener.java

+            } else if (ownedElement instanceof OpaqueAction internalAction) {
+                unfoldRedefinableElement(internalAction, nameToArgument);
+            } else if (ownedElement instanceof Constraint) {
+                // Constraints cannot be parameterized.


Suggested change

// Constraints cannot be parameterized.

// Constraints cannot refer to activity parameters.

darets97 added 3 commits November 12, 2025 13:41

#635 Add TemplateParameterFlattener

22bb454

#635 Move composite datatype flattener tests

e772fb7

#635 Add test for template parameter flattening

c5301fe

darets97 requested a review from AndreaPuffo November 12, 2025 12:48

darets97 linked an issue Nov 12, 2025 that may be closed by this pull request

UML to CIF: Add parameterization support #635

Open

darets97 removed a link to an issue Nov 12, 2025

UML to CIF: Add parameterization support #635

Open

dhendriks changed the title ~~635 add parameterization support to the cif translator~~ WIP 635 add parameterization support to the cif translator Nov 14, 2025

darets97 added 2 commits November 17, 2025 16:59

#635 Flatten child and refresh context after flattening

f9b5e7e

#635 add test with fork and add with_orphan to existing test

a930a35

darets97 changed the title ~~WIP 635 add parameterization support to the cif translator~~ 635 add parameterization support to the cif translator Nov 17, 2025

darets97 changed the title ~~635 add parameterization support to the cif translator~~ 635 add parameterization support to the uml2cif translator Nov 18, 2025

darets97 changed the title ~~635 add parameterization support to the uml2cif translator~~ 635 Add support for parameterized activity to the uml2cif translators Nov 18, 2025

#625 Remove exception for parameterized activities in umltocif

e00e326

AndreaPuffo reviewed Nov 18, 2025

View reviewed changes

darets97 and others added 6 commits November 18, 2025 20:16

Apply suggestions from code review

446c4b6

Co-authored-by: AndreaPuffo <46629578+AndreaPuffo@users.noreply.github.com>

#635 Add code comment

ec375be

#635 Rename argumentMap to nameToArgument

0ce4df2

#635 Refactor stereotype comparison method

2f32cc0

#635 Fix misspelling of addressable

169061f

#635 Add docs to activity flattening regression tests

4263bb9

darets97 requested a review from dhendriks November 18, 2025 19:26

dhendriks requested changes Nov 27, 2025

View reviewed changes

		@@ -72,9 +81,21 @@ private void transform(Element element) {
		if (element instanceof Activity activityElement) {

	// Constraints cannot be parameterized.
	// Constraints cannot refer to activity parameters.

Conversation

darets97 commented Nov 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dhendriks commented Nov 14, 2025

Uh oh!

darets97 commented Nov 17, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

AndreaPuffo commented Nov 18, 2025

Uh oh!

darets97 commented Nov 18, 2025

Uh oh!

AndreaPuffo commented Nov 21, 2025

Uh oh!

dhendriks commented Nov 21, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

darets97 commented Nov 12, 2025 •

edited

Loading