#683 Add activity constraints by AndreaPuffo · Pull Request #684 · TNO/SynthML

AndreaPuffo · 2026-02-11T09:43:13Z

Closes #683.

I will add a regression test once the changes are approved.

UmlToCifTranslator: translate activity requirements

AndreaPuffo · 2026-02-12T10:15:20Z

Documentation to be updated as well.

dhendriks · 2026-02-20T14:19:34Z

...yoke.transform.uml2cif/src/com/github/tno/pokayoke/transform/uml2cif/UmlToCifTranslator.java

Need to update the method JavaDoc.

dhendriks · 2026-02-20T14:19:43Z

...yoke.transform.uml2cif/src/com/github/tno/pokayoke/transform/uml2cif/UmlToCifTranslator.java

        }

+        // Translate activity requirements.
+        for (Constraint umlConstraint: activity.getOwnedRules()) {


Is it sufficient to translate the requirements like this? Should we also include all requirements of other activities that we call, etc? (all other 'relevant' activities)

I did this to be consistent with the occurrence constraints: these are considered only during the activity synthesis, not when an activity is called. Better to have a conversation offline about this.

dhendriks · 2026-02-20T14:20:00Z

...thub.tno.synthml.uml.profile.util/src/com/github/tno/synthml/uml/profile/cif/CifContext.java

        return constraint.getContext() instanceof PrimitiveType;
    }

+    public static boolean isActivityRequirement(Constraint constraint) {


Move isActivityRequirement to just after isActivityPostconditionConstraint.

dhendriks · 2026-02-20T14:20:06Z

...thub.tno.synthml.uml.profile.util/src/com/github/tno/synthml/uml/profile/cif/CifContext.java

        return constraint.getContext() instanceof PrimitiveType;
    }

+    public static boolean isActivityRequirement(Constraint constraint) {


Rename isActivityRequirement to isActivityRequirementConstraint, to match other methods?

dhendriks · 2026-02-20T14:20:11Z

...thub.tno.synthml.uml.profile.util/src/com/github/tno/synthml/uml/profile/cif/CifContext.java


+    public static boolean isActivityRequirement(Constraint constraint) {
+        return constraint.getContext() instanceof Activity activity
+                // It is the correct type of constraint.


Can't we check that it is a FormalConstraint?

It was my first choice, but I then wrote it this way to be consistent with the rest of the class and structure that we have e.g., in the validator. To be honest, if I write a isRequirementConstraint method in PokaYokeUmlProfileUtil, this method in CifContext is not needed at all. But it will not be consistent with the rest of validation, for instance.
I will remove this method and add a new one in PokaYokeUmlProfileUtil, and let's see how it looks. I think it looks better; but if consistency with the rest is more important we can revert back to this.

dhendriks · 2026-02-20T14:21:52Z

...hml.uml.profile.util/src/com/github/tno/synthml/uml/profile/util/PokaYokeUmlProfileUtil.java

Rename to isClassRequirementConstraint?

dhendriks · 2026-02-20T14:22:06Z

...profile.util/src/com/github/tno/synthml/uml/profile/validation/PokaYokeProfileValidator.java

+                .filter(r -> CifContext.isActivityRequirement(r)).map(Constraint.class::cast)
+                .collect(Collectors.toCollection(LinkedHashSet::new));
+
+        if (!members.equals(Sets.union(Sets.union(preAndPostconditions, intervalConstraints), activityRequirements))) {


I think Sets.union supports also giving 3 sets instead of 2, right?

Not sure how to make it work, so I created a set union with stream.

dhendriks · 2026-02-20T14:22:25Z

...profile.util/src/com/github/tno/synthml/uml/profile/validation/PokaYokeProfileValidator.java

            checkValidActivityPrePostconditionConstraint(constraint);
-        } else if (CifContext.isClassConstraint(constraint)) {
-            checkValidClassConstraint(constraint);
+        } else if (CifContext.isClassConstraint(constraint) || (CifContext.isActivityRequirement(constraint))) {


Does it still make sense to have CifContext.isClassConstraint? Should we rename it to CifContext.isClassRequirementConstraint?

See previous comments.

dhendriks · 2026-02-20T14:22:49Z

...profile.util/src/com/github/tno/synthml/uml/profile/validation/PokaYokeProfileValidator.java

    }

-    private void checkValidClassConstraint(Constraint constraint) {
+    private void checkValidClassOrActivityConstraint(Constraint constraint) {


This is only requirements, from classes and activities, right? So, maybe rename to checkValidRequirementConstraint?

dhendriks · 2026-02-20T14:23:01Z

...profile.util/src/com/github/tno/synthml/uml/profile/validation/PokaYokeProfileValidator.java

Why check this with a global scope? Why not in the scope of the activity, if it is in an activity?

dhendriks · 2026-02-20T14:24:19Z

Does editing these new constraints with the SynthML tab work?

AndreaPuffo · 2026-02-25T09:15:16Z

Does editing these new constraints with the SynthML tab work?

A quick example of how this works. This is the model: 2 class requirements and 2 activities, each with its own activity requirements.

Editing one activity constraint looks like this:

And finally the CIF translation of the activities (Activity1 top, Activity 2 bottom):

...yoke.transform.uml2cif/src/com/github/tno/pokayoke/transform/uml2cif/UmlToCifTranslator.java

dhendriks · 2026-03-04T16:46:54Z

...hml.uml.profile.util/src/com/github/tno/synthml/uml/profile/util/PokaYokeUmlProfileUtil.java

@@ -529,7 +528,7 @@ public static List<Stereotype> getSupportedConstraintStereotypes(Constraint cons
        } else if (isPostconditionConstraint(constraint)) {
            return List.of(getStereotype(constraint, ST_POSTCONDITION));
        } else if (isClassRequirement(constraint)) {


I always forget that Activity inherits from Class. Super non-intuitive. I'd maybe rename the method to isClassOrActivityRequirementConstraint, and there add a comment in the body like // Note that 'Activity' inherits from 'Class'. or so?

dhendriks · 2026-03-04T16:47:35Z

...hml.uml.profile.util/src/com/github/tno/synthml/uml/profile/util/PokaYokeUmlProfileUtil.java

        return appliedStereotypes.get(0).getName().equals(ST_USAGE_PRECONDITION);
    }

+    public static boolean isRequirementConstraint(Constraint constraint) {


Maybe move isPostconditionConstraint and isClassRequirement to just above isSynthesisPrecondition, to have methods with similar implementation close together?

dhendriks · 2026-03-04T16:47:48Z

...hml.uml.profile.util/src/com/github/tno/synthml/uml/profile/util/PokaYokeUmlProfileUtil.java

        return appliedStereotypes.get(0).getName().equals(ST_USAGE_PRECONDITION);
    }

+    public static boolean isRequirementConstraint(Constraint constraint) {


There are three methods for 'where' the constraint is (precondition/postcondition of activity, rule of a class/activity), and three methods about what kind (synthesis pre, usage pre, requirement).
I'm thinking the names could be clearer. Maybe:

isSynthesisPreconditionConstraint/isUsagePreconditionConstraint/isRequirementConstraint to just check the stereotype that is applied, more or less as we have now (but all end their name with Constraint).

isPreconditionConstraint/isPostconditionConstraint/isClassRequirementConstraint -> isContainedAsActivityPrecondition/isContainedAsActivityPostcondition/isContainedAsClassOrActivityOwnedRule to see where they are contained in the model. That distinguishes their names better.

...profile.util/src/com/github/tno/synthml/uml/profile/validation/PokaYokeProfileValidator.java

dhendriks · 2026-03-04T16:48:19Z

...profile.util/src/com/github/tno/synthml/uml/profile/validation/PokaYokeProfileValidator.java

-        } else if (CifContext.isClassConstraint(constraint)) {
-            checkValidClassConstraint(constraint);
+        } else if (CifContext.isClassConstraint(constraint)
+                || (PokaYokeUmlProfileUtil.isRequirementConstraint(constraint)))


Can it ever be a requirement constraint and not a class constraint? What constraints that we support are allowed in classes that are not requirements?
In other words, can't we only check for being a requirement constraint, as that also matches checkValidRequirementConstraint?

This should be fixed with the new methods.

...profile.util/src/com/github/tno/synthml/uml/profile/validation/PokaYokeProfileValidator.java

dhendriks · 2026-03-04T16:49:08Z

...profile.util/src/com/github/tno/synthml/uml/profile/validation/PokaYokeProfileValidator.java

    }

    @Check
    private void checkValidConstraint(Constraint constraint) {


I wonder if we should check here for what kind of constraint it is, and then in the methods we invoke, that they are in the right place (a supported place), maybe? Now it seems mixed.
Together with the renaming of the 6 methods in PokaYokeUmlProfileUtil (see other comment), I think we could probably remove the CifContext methods, and make it a lot cleaner. I don't think it would give a lot of changes in many places. Maybe a few of the context methods need an extra method in the profile util then, though.

Added new methods in PokaYokeUmlProfileUtil and removed a few from CifContext.

Co-authored-by: Dennis Hendriks <dh_tue@hotmail.com>

UmlToCifTranslator, FlattenUmlActivity: rename methods

- make methods public - add occurrence constraint and primitive type constraint methods PokaYokeProfileValidator: use the new methods

UmlToCameoTransformer, Uml2GalTranslator, PokaYokeProfileValidator: use the PokaYokeUmlProfileUtil method

AbstractActivityDependencyOrderer: use the PokaYokeUmlProfileUtil method

constraint PokaYokeProfileValidator: use the PokaYokeUmlProfileUtil methods

AndreaPuffo · 2026-03-10T09:56:25Z

Ready for review, best commit-by-commit.

AndreaPuffo added 4 commits February 10, 2026 18:21

#683 CifContext: add isActivityRequirement method

12cb8f6

#683 PokaYokeProfileValidator: allow activity requirement constraints

58705a8

UmlToCifTranslator: translate activity requirements

#683 PokaYokeProfileValidator: rename method

6fe4ef6

#683 PokaYokeUmlProfileUtil, PokaYokeProfileValidator: rename stereotype

212a07b

AndreaPuffo requested a review from dhendriks February 11, 2026 09:43

AndreaPuffo linked an issue Feb 11, 2026 that may be closed by this pull request

Add activity constraints #683

Open

dhendriks requested changes Feb 20, 2026

View reviewed changes

AndreaPuffo added 10 commits February 25, 2026 08:19

#683 UmlToCifTranslator: update JavaDoc.

3bb41f9

#683 CifContext: move method isActivityRequirement.

0fa177a

#683 CifContext, UmlToCifTranslator, PYProfileValidator: rename method

a468205

#683 CifContext: remove isActivityRequirementConstraint

19fa69f

#683 PokaYokeUmlProfileUtil: add isRequirementConstraint method

6b5dc4d

#683 PokaYokeProfileValidator, UmlToCifTranslator: use new method

8a1f8c1

#683 PokaYokeUmlProfileUtil: rename method.

ee430c6

#683 PokaYokeProfileValidator: create set union before check.

3127da1

#683 PokaYokeProfileValidator: rename method.

5aa521f

#683 PokaYokeProfileValidator: use scoped context.

ab173a0

dhendriks requested changes Mar 4, 2026

View reviewed changes

AndreaPuffo and others added 9 commits March 9, 2026 14:13

#683 Apply suggestions from code review

549e163

Co-authored-by: Dennis Hendriks <dh_tue@hotmail.com>

#683 PokaYokeProfileValidator: change variable name after review

8cd8aac

#683 PokaYokeUmlProfileUtil: move methods.

f689a77

#683 PokaYokeUmlProfileUtil: rename methods.

686be24

#683 PokaYokeUmlProfileUtil: rename methods

281f185

UmlToCifTranslator, FlattenUmlActivity: rename methods

#683 PokaYokeUmlProfileUtil:

1c52cc8

- make methods public - add occurrence constraint and primitive type constraint methods PokaYokeProfileValidator: use the new methods

#683 CifContext: remove isPrimitiveTypeConstraint

49a6a8e

UmlToCameoTransformer, Uml2GalTranslator, PokaYokeProfileValidator: use the PokaYokeUmlProfileUtil method

#683 CifContext: remove isOccurrenceConstraint

3312f5d

AbstractActivityDependencyOrderer: use the PokaYokeUmlProfileUtil method

#683 CifContext: remove method to check activity pre/post condition

e623614

constraint PokaYokeProfileValidator: use the PokaYokeUmlProfileUtil methods

AndreaPuffo added 3 commits March 10, 2026 08:53

#638 PokaYokeProfileValidator: update if-clause with new methods

0487e95

#638 PokaYokeUmlProfileUtil: add comment

2f63429

#638 UmlToCifTranslator: reformat file

f0ba3f0

Conversation

AndreaPuffo commented Feb 11, 2026

Uh oh!

AndreaPuffo commented Feb 12, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dhendriks commented Feb 20, 2026

Uh oh!

AndreaPuffo commented Feb 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

AndreaPuffo commented Mar 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

AndreaPuffo commented Feb 25, 2026 •

edited

Loading