Switches to using validateJSON#1213
Merged
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
🚀 New features to boost your workflow:
|
Collaborator
|
Please add a meaningful self-descriptive name to the PR. |
tupaschoal
reviewed
Jul 1, 2025
tupaschoal
left a comment
Collaborator
There was a problem hiding this comment.
Could you redo the first commit to use git mv instead? Then it will be recorded as a file rename, instead of a file deletion + file addition.
Other than that seems fine, since validateJSON has pretty good test coverage on its own.
tupaschoal
approved these changes
Jul 11, 2025
Collaborator
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
Closes #1052
Context / Background
We were using an RYO solution, and this moves us to validateJSON.
What change is being introduced by this PR?
How will this be tested?
All automated tests should still pass. The app should refuse to import a broken ttldb file.