Move unsafe-inline scripts to listeners#1215
Draft
Atomic-Germ wants to merge 2 commits into
Draft
Conversation
Codecov Report❌ Patch coverage is
... and 4 files with indirect coverage changes 🚀 New features to boost your workflow:
|
| { | ||
| const entry = convertTimeFormat(this.value); | ||
| this.value = entry; | ||
| changeValue(this.name, entry); |
Collaborator
There was a problem hiding this comment.
what about this call?
Collaborator
|
Moving to draft until issue is answered |
tupaschoal
marked this pull request as draft
July 1, 2025 10:57
Atomic-Germ
force-pushed
the
fix/move-js-to-listeners
branch
from
August 25, 2025 22:41
c2056cd to
a2184a1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context / Background
Right now, the logic that corrects inputs in the preferences pane is done in unsafe-inline scripts, which electron complains about due to security policy.
What change is being introduced by this PR?
I've moved the inlines into listeners in preferences.js, and a adjusted a couple existing ones.
How will this be tested?
Open up the devtools, change an option, and you shouldn't get any content security warnings.