Skip to content

Fixes main window test delay#1216

Closed
Atomic-Germ wants to merge 1 commit into
TTLApp:mainfrom
Atomic-Germ:fix/test-main
Closed

Fixes main window test delay#1216
Atomic-Germ wants to merge 1 commit into
TTLApp:mainfrom
Atomic-Germ:fix/test-main

Conversation

@Atomic-Germ

Copy link
Copy Markdown
Contributor

Right now, the first test in tests/main-window takes a stupidly long time. This patch fixes that, but I'm not entirely sure of why it fixes it.

What change is being introduced by this PR?

  • adds await window.waitForLoadState('domcontentloaded') after const window = await electronApp.firstWindow();.

How will this be tested?

The normal tests should be a lot faster.

@codecov

codecov Bot commented Jun 17, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant