Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only show volume overlay when volume has actually changed #1503

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

karjo24
Copy link
Contributor

@karjo24 karjo24 commented Feb 26, 2025

Motivation and Context

#1295. While this is not a perfect solution, it is an improvement to the status quo.

Description

Checks if volume has actually changed and shows/doesn't show icon overlay accordingly.

Steps for Testing

Prerequisites:

  • 1 Stream/VOD
  1. Navigate to the video and check if the overlays stop showing once full/no volume is reached.

@karjo24 karjo24 linked an issue Feb 26, 2025 that may be closed by this pull request
@karjo24 karjo24 self-assigned this Feb 26, 2025
@karjo24 karjo24 requested a review from a team February 26, 2025 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

more precise visual feedback when adjusting volume using keybinds
2 participants