Yuhua's PR AC 1-7 #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 12 commits
November 6, 2023 15:32
falconwoo
reviewed
Nov 7, 2023
|
|
||
| if ((pageIndex * pageSize) > companies.Count()) | ||
| { | ||
| return StatusCode(StatusCodes.Status204NoContent); |
There was a problem hiding this comment.
well: nice to use 204 for no found related data
suggestion: also return empty list to client
| { | ||
| return StatusCode(StatusCodes.Status204NoContent); | ||
| } | ||
| var ressultCompanies = companies.Skip((int)((pageIndex - 1) * pageSize)).Take((int)pageSize).ToList(); |
There was a problem hiding this comment.
well: nice to use Skip Take
sugesstion: extract (pageIndex-1) * pageSize to a temp variable
| var company = companies.Find(company => company.Id.Equals(id)); | ||
| if (company == null) | ||
| { | ||
| return NotFound(); |
There was a problem hiding this comment.
well: nice to return 404 if not found company
| PUT https://{{hostname}}:{{port}}/api/Companies/{companyID}/employee/{employeeId} | ||
| Content-Type: application/json; charset=utf-8 | ||
|
|
There was a problem hiding this comment.
suggestion: add request body for update company
lklgithub
reviewed
Nov 7, 2023
| @@ -20,6 +23,75 @@ public ActionResult<Company> Create(CreateCompanyRequest request) | |||
| return StatusCode(StatusCodes.Status201Created, companyCreated); | |||
| } | |||
|
|
|||
| [HttpGet] | |||
| } | ||
|
|
||
| [Fact] | ||
| public async Task Should_return_companies_with_status_200_when_get_company_given_page_and_index() |
There was a problem hiding this comment.
Suggest add one test case(such as pageIndex = -1 & pageSize = -2)
There was a problem hiding this comment.
maybe this case make code logic success, but not satisfied
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.