Kailin company api #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
November 6, 2023 17:34
celianiu
reviewed
Nov 7, 2023
| { | ||
| // Given | ||
| Company companyGiven = new Company("slb"); | ||
| HttpResponseMessage httpResponseMessage = await httpClient.PostAsJsonAsync("/api/companies",companyGiven); |
There was a problem hiding this comment.
Good: Use one httpResponseMessage to handle all httpResponses. easy to read!👍
celianiu
reviewed
Nov 7, 2023
| { | ||
| // Given | ||
| await ClearDataAsync(); | ||
| Company companyGiven = new Company("slb"); |
There was a problem hiding this comment.
To Improve: Better use CreateCompanyRequest and CreateEmployeeRequest since FE doesn't provide ID
falconwoo
reviewed
Nov 7, 2023
|
|
||
| ## AC9 Update Employee | ||
| PUT https://{{hostname}}:{{port}}/api/companies/{companyId}/employees/{employeeId} | ||
|
|
| ## DELETE /api/companies/companyID/employees/{employeeId} | ||
|
|
||
| ## AC6 Create Employee API | ||
| PUT https://{{hostname}}:{{port}}/api/companies/{companyId}/employees |
There was a problem hiding this comment.
suggestion: use POST instead of PUT to create resource
| } | ||
|
|
||
| var startIndex = (pageIndex - 1) * pageSize; | ||
| var pagedCompanies = companies.Skip(startIndex).Take(pageSize).ToList(); |
| var company = companies.Find(c => c.Id == companyId); | ||
| if (company is null) | ||
| { | ||
| return BadRequest(); |
There was a problem hiding this comment.
suggestion: return 404 if the company can not be found
celianiu
reviewed
Nov 7, 2023
| [HttpGet] | ||
| public ActionResult<List<Company>> GetAllByIndex([FromQuery] int pageSize = 0, [FromQuery] int pageIndex = 1) | ||
| { | ||
| if (pageSize <= 0 || pageIndex <= 0) |
There was a problem hiding this comment.
Good: Give a init pageSize and pageIndex value. Stick with the rules!🤩
|
Good: Smalls step & clear code logic easy to read; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.