HW_Wang_Ke #3
Open
HW_Wang_Ke #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…when getAll companies.
…eturn 404 not found if not existing.
…et with query pagesize and index.
…and if the company not found then return NotFound 404 status code
…turn not found if the id of company not exsiting and created if adding successfully.
…d will return no found if the id of company or employee is not exsiting.
falconwoo
reviewed
Nov 7, 2023
CompanyApi/api.http
Outdated
|
|
||
| ## Response | ||
| ## 1.Updated, Return the Pet updated with Status OK ( 200 ) | ||
| ## 2.Not Found, Return Status Not Found ( 404 ) |
There was a problem hiding this comment.
to be improved: we also need to design api for employee
There was a problem hiding this comment.
Thx, updated the apis.http design
| { | ||
| List<Company> onePageCompanies = new List<Company>(); | ||
| int startIdx = (int)((index - 1) * page_size); | ||
| for (int i = 0; i < page_size && (i + startIdx) < companies.Count; i++) |
There was a problem hiding this comment.
suggestion: we can try to use Skip Take to do the same thing
| return existingCompany; | ||
| } | ||
|
|
||
| [HttpPost("{company_id}")] |
There was a problem hiding this comment.
to be improved: the URL for create employee in company should be {companyId}/employees
| return theCompanyToJoin == null ? NotFound($"The company with id {company_id} does not exist.") : Created("", newEmployee); | ||
| } | ||
|
|
||
| [HttpDelete("{company_id}/{employee_id}")] |
There was a problem hiding this comment.
to be improved: the URL for delete employee in company should be {companyId}/employees/{employeeId}
|
well:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.