Shuhan Jin #5
Open
Shuhan Jin #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slb-bgc-wk
reviewed
Nov 7, 2023
| if (pageSize != null && pageIndex != null) | ||
| { | ||
| var startIndex = (pageIndex - 1) * pageSize; | ||
| var companiesPage = companies.Skip((int)startIndex).Take((int)pageSize).ToList(); |
There was a problem hiding this comment.
WangKe:
Great using of the Linq syntax 👍
slb-bgc-wk
reviewed
Nov 7, 2023
| //employee.Id = Guid.NewGuid().ToString(); | ||
| company.Employees.Add(employee); | ||
|
|
||
| return Ok(employee); |
There was a problem hiding this comment.
As we add new employee here, maybe [return Created(employee)] could be better
|
WangKe:
Improves: |
falconwoo
reviewed
Nov 7, 2023
| Content-Type: application/json; charset=utf-8 | ||
|
|
||
| Company: |
There was a problem hiding this comment.
suggestion: not need this json for company, we find related company by companyID in the URL
| ### Case1: success, 204 no content | ||
| ### Case2: 404 Company NOT Found | ||
| ### Case3: 404 emloyee NOT Found |
There was a problem hiding this comment.
to be improved: we also need to design api for AC 8-10
| var company = companies.Find(c => c.Id == companyId); | ||
| if (company == null) | ||
| { | ||
| return NotFound(); |
There was a problem hiding this comment.
well: use 404 if company can not be found👍
| if (pageSize != null && pageIndex != null) | ||
| { | ||
| var startIndex = (pageIndex - 1) * pageSize; | ||
| var companiesPage = companies.Skip((int)startIndex).Take((int)pageSize).ToList(); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.