11.06 happy and lovely homework-pengyu #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
November 6, 2023 17:16
falconwoo
reviewed
Nov 7, 2023
| company?.Employees.Remove(employee); | ||
| return NoContent(); | ||
| } | ||
| [HttpPost("{companyId}/employees")] |
There was a problem hiding this comment.
suggestion: add new line to separate two methods
|
to be improved: missing api design for employee |
|
Good points:
To be improved: |
jingwang315
reviewed
Nov 7, 2023
| CreateCompanyRequest companyGiven = new CreateCompanyRequest("BlueSky Digital Media"); | ||
| HttpResponseMessage postResponseMessage = await httpClient.PostAsJsonAsync("/api/companies", companyGiven); | ||
| var createdCompany = await postResponseMessage.Content.ReadFromJsonAsync<Company>(); | ||
| var createdEmployee = new EmployeeRequest("pengyu"); |
There was a problem hiding this comment.
Suggestion: use givenEmployee when creating an employee request; use createdEmployee read from postResponseMessage because that's successfully created.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.