-
Notifications
You must be signed in to change notification settings - Fork 4
kailin MiniBlog #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
… article and user repository
…ticle and user repository
well
to be improved
|
|
||
namespace MiniBlog.Repositories | ||
{ | ||
public class UserRepository : IUserRepository |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well: nice to also provide repository for user
mockUserRepository.Setup(repository => repository.GetUserByName(It.IsAny<string>())).ReturnsAsync((User)null); | ||
mockUserRepository.Setup(repository => repository.CreateUser(It.IsAny<User>())).ReturnsAsync((User user) => user); | ||
|
||
//var articleStore = new ArticleStore(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: remove dead code
await userResponseAfterDeletion.Content.ReadAsStringAsync()); | ||
Assert.True(usersLeft.Count == 0); | ||
} | ||
//[Fact] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: remove dead code
No description provided.