MiniBlogByWangJing #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjin9
reviewed
Nov 8, 2023
| @@ -18,7 +18,7 @@ public TestBase(CustomWebApplicationFactory<Startup> factory) | |||
|
|
|||
| protected CustomWebApplicationFactory<Startup> Factory { get; } | |||
|
|
|||
| protected HttpClient GetClient(ArticleStore articleStore = null, UserStore userStore = null, IArticleRepository articleRepository = null) | |||
| protected HttpClient GetClient(ArticleStore articleStore = null, UserStore userStore = null, IArticleRepository articleRepository = null, IUserRepository userRepository = null) | |||
| { | |||
| return Factory.WithWebHostBuilder(builder => | |||
| { | |||
There was a problem hiding this comment.
should inject IUserRepository in testbase
| @@ -13,6 +13,7 @@ public class ArticleService | |||
| private readonly ArticleStore articleStore = null!; | |||
| private readonly UserStore userStore = null!; | |||
| private readonly IArticleRepository articleRepository = null!; | |||
| private readonly IUserRepository userRepository = null!; | |||
|
|
|||
| public ArticleService(ArticleStore articleStore, UserStore userStore, IArticleRepository articleRepository) | |||
| { | |||
There was a problem hiding this comment.
should inject IUserRepository userRepository in ArticleService
|
well:
to be improved:
|
falconwoo
reviewed
Nov 9, 2023
|
|
||
| namespace MiniBlog.Repositories | ||
| { | ||
| public class UserRepository : IUserRepository |
There was a problem hiding this comment.
well: nice to also provide repository for user
| @@ -13,6 +13,7 @@ public class ArticleService | |||
| private readonly ArticleStore articleStore = null!; | |||
| private readonly UserStore userStore = null!; | |||
| private readonly IArticleRepository articleRepository = null!; | |||
| private readonly IUserRepository userRepository = null!; | |||
There was a problem hiding this comment.
suggestion: need add to constructor if you want to inject
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.