Yuhua's PR #3
Open
Yuhua's PR #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
|
jingwang315
reviewed
Nov 8, 2023
| private readonly IArticleRepository articleRepository = null; | ||
| private readonly IUserRepository userRepository = null; | ||
|
|
||
| public ArticleService(ArticleStore articleStore, UserStore userStore, IArticleRepository articleRepository, IUserRepository userRepository) |
| string articleTitle = "Good day"; | ||
|
|
||
| Article article = new Article(userNameWhoWillAdd, articleTitle, articleContent); | ||
| User newUser = new User(userNameWhoWillAdd); |
|
Good points:
|
falconwoo
reviewed
Nov 9, 2023
| public ArticleController(ArticleService articleService) | ||
| public ArticleController(ArticleStore articleStore, UserStore userStore, UserService userService, ArticleService articleService) | ||
| { | ||
| //this.articleStore = articleStore; |
| public async Task<List<Article>> ListAsync() | ||
| { | ||
| return await articleService.GetAll(); | ||
| Console.WriteLine(articleService.GetAllAsync()); |
| { | ||
| private readonly ArticleStore articleStore = null!; | ||
| private readonly UserStore userStore = null!; | ||
| private readonly ArticleService articleService = null!; |
There was a problem hiding this comment.
suggestion: remove unused articleService
|
|
||
| namespace MiniBlog.Repositories | ||
| { | ||
| public class UserRepository : IUserRepository |
There was a problem hiding this comment.
well: nice to also provide repository for user
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry for single commit message; Forget to fork to my own repo