shuhan jin #5
Open
shuhan jin #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to articleRepository
lklgithub
reviewed
Nov 8, 2023
|
|
||
| public ArticleService(ArticleStore articleStore, UserStore userStore, IArticleRepository articleRepository) | ||
| public ArticleService(ArticleStore articleStore, UserStore userStore, IArticleRepository articleRepository, IUserRepository userRepository) |
There was a problem hiding this comment.
maybe not need ArticleStore and UserStore class
| string userNameWhoWillAdd = "Tom"; | ||
| string articleContent = "What a good day today!"; | ||
| string articleTitle = "Good day"; | ||
| Article article = new Article(userNameWhoWillAdd, articleTitle, articleContent); | ||
|
|
||
| var userStore = new UserStore(new List<User>()); |
There was a problem hiding this comment.
suggest code line from 68 to70 move to constructor
| @@ -18,7 +18,7 @@ public TestBase(CustomWebApplicationFactory<Startup> factory) | |||
|
|
|||
| protected CustomWebApplicationFactory<Startup> Factory { get; } | |||
|
|
|||
| protected HttpClient GetClient(ArticleStore articleStore = null, UserStore userStore = null, IArticleRepository articleRepository = null) | |||
| protected HttpClient GetClient(ArticleStore articleStore = null, UserStore userStore = null, IArticleRepository articleRepository = null, IUserRepository userRepository = null) | |||
| { | |||
| return Factory.WithWebHostBuilder(builder => | |||
There was a problem hiding this comment.
suggest add this code in line 37:
services.AddScoped();
services.AddScoped(provider =>
{
return articleRepository;
});
services.AddScoped(provider =>
{
return userRepository;
});
falconwoo
reviewed
Nov 9, 2023
|
|
||
| namespace MiniBlog.Repositories | ||
| { | ||
| public class UserRepository : IUserRepository |
There was a problem hiding this comment.
well: nice to also implement repository for user
| @@ -13,38 +13,50 @@ public class ArticleService | |||
| private readonly ArticleStore articleStore = null!; | |||
There was a problem hiding this comment.
suggestion: remove unused variable like articleStore & userStore
| } | ||
|
|
||
| /*public async Task<Article?> CreateArticle(Article article) |
| } | ||
|
|
||
| public async Task<User> GetByName(string username) | ||
| => await userRepository.GetByName(username); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.