ParkingLotApiByWangJing #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
celianiu
reviewed
Nov 9, 2023
| public async Task<ParkingLot> UpdateParkingLotAsync(string id, CapacityDto capacityDto) | ||
| { | ||
| ParkingLot parkingLot = await GetByIdAsync(id); | ||
| if (capacityDto.Capacity < 10 || capacityDto.Capacity < parkingLot.Capacity) |
celianiu
reviewed
Nov 9, 2023
| { | ||
| throw new InvalidPageIndexException(); | ||
| } | ||
| return parkingLots.Skip(pagesToBeSkip).Take(pageSize).ToList(); |
There was a problem hiding this comment.
Improve: Better get by page in repository instead of getAll and filter in service
|
Good: small step commit |
falconwoo
reviewed
Nov 9, 2023
| namespace ParkingLotApi.Exceptions | ||
| { | ||
| [Serializable] | ||
| internal class InvalidPageIndexException : Exception |
There was a problem hiding this comment.
well: nice to define customized exception
|
|
||
| namespace ParkingLotApi.Filters | ||
| { | ||
| public class InvalidPageIndexExceptionFilter : IActionFilter, IOrderedFilter |
There was a problem hiding this comment.
well: nice to add more than one exception filter
| { | ||
| public class InvalidPageIndexExceptionFilter : IActionFilter, IOrderedFilter | ||
| { | ||
| public int Order => 2; |
There was a problem hiding this comment.
well: nice to set different order for each filter
|
|
||
| public async Task<List<ParkingLot>> GetInPageAsync(int pageIndex) | ||
| { | ||
| List<ParkingLot> parkingLots = await GetAsync(); |
There was a problem hiding this comment.
suggestion: this code will return all data, might cause issue if there is huge amount of data in db
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.