kailin parking lot api #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
November 8, 2023 13:05
sjin9
reviewed
Nov 9, 2023
|
|
||
| if (pageIndex < 0) | ||
| { | ||
| throw new PageInfoInvalidException(); |
|
well:
|
|
To be improved:
|
falconwoo
reviewed
Nov 9, 2023
| [HttpPost] | ||
| public async Task<ActionResult<ParkingLotDto>> CreateParkingLotAsync([FromBody] ParkingLotDto parkingLotDto) | ||
| { | ||
| //try |
| @@ -0,0 +1,6 @@ | |||
| namespace ParkingLotApi.Exceptions | |||
There was a problem hiding this comment.
well: nice to define customized exception
|
|
||
| namespace ParkingLotApi.Filters | ||
| { | ||
| public class PageInfoInvalidExceptionFilter : IActionFilter, IOrderedFilter |
There was a problem hiding this comment.
well: nice to add more than one exception filter
| { | ||
| public class PageInfoInvalidExceptionFilter : IActionFilter, IOrderedFilter | ||
| { | ||
| int IOrderedFilter.Order => int.MaxValue - 10; |
There was a problem hiding this comment.
suggestion: this value might need to be different for each filter
| public Task<ParkingLot> GetParkingLotById(string id); | ||
| public Task DeleteParkingLotById(string id); | ||
| public Task<List<ParkingLot>> GetParkingLotByPageInfo(int pageIndex, int pageSize); | ||
| public Task<List<ParkingLot>> GetAllParkingLot(); |
There was a problem hiding this comment.
suggestion: there is no requirement for getting all data
|
|
||
| public async Task<List<ParkingLot>> GetParkingLotByPageInfo(int pageIndex) | ||
| { | ||
| int pageSize = 15; |
There was a problem hiding this comment.
suggestion: this variable can be extracted as constant
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.