WangKe's HW #4
Open
WangKe's HW #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he parking lot with lessThan10 capacity.
…nvalidCapacity exception.
…and ParkingLotsController.
…sService and ParkingLotsController.
|
well
|
falconwoo
reviewed
Nov 9, 2023
| public async Task<ActionResult<List<ParkingLotEntity>>> GetParkingLotById(string id) | ||
| { | ||
| var parkingLot = await _parkingLotsService.GetByIdAsync(id); | ||
| if (parkingLot == null) |
There was a problem hiding this comment.
suggestion: avoid return null from method, since null is hard to understand. here we can throw exception from service
| } | ||
|
|
||
| [HttpPut("{id}")] | ||
| public async Task<ActionResult<ParkingLotEntity>> UpdateCapacityAsync(string id, [FromBody] int capacity) |
There was a problem hiding this comment.
suggestion: use class for request body instead of int
| var updatedParkingLot = await _parkingLotsService.UpdateCapacity(id, capacity); | ||
| if (updatedParkingLot == null) | ||
| { | ||
| return NotFound(); |
There was a problem hiding this comment.
suggestion: this can also be handled in global exception handler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.