Shuhan Jin-homework with adult step commit #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jingwang315
reviewed
Nov 9, 2023
| //try | ||
| //{ | ||
| return StatusCode(StatusCodes.Status201Created, await _parkingLotsService.AddAsync(parkingLotDto)); | ||
| //} |
| [HttpGet] | ||
| public async Task<ActionResult<List<ParkingLot>>> GetOnePageAsync([FromQuery] int? pageIndex) | ||
| { | ||
| if (pageIndex == null) |
|
|
||
| public async Task<ParkingLot> GetById(string ParkingLotId) | ||
| { | ||
| return await _parkingLotCollection.Find(p => p.Id == ParkingLotId).FirstAsync(); |
There was a problem hiding this comment.
Suggestion: use FirstOrDefaultAsync instead.
|
Good points:
To be improved:
|
falconwoo
reviewed
Nov 9, 2023
| [HttpPost] | ||
| public async Task<ActionResult<ParkingLotDto>> AddParkingLotAsync([FromBody] ParkingLotDto parkingLotDto) | ||
| { | ||
| //try |
| pageIndex = 1; | ||
| return Ok(await _parkingLotsService.GetOnePageAsync((int)pageIndex)); | ||
| } | ||
| else |
There was a problem hiding this comment.
suggestion: else can be removed, since there is no other branch
| public async Task<ActionResult> GetParkingLotByIdAsync(string id) | ||
| { | ||
| var parkingLot = await _parkingLotsService.GetByIdAsync(id); | ||
| if (parkingLot == null) |
There was a problem hiding this comment.
suggestion: avoid return null from method, since it's hard to understand the meaning
| throw new InvalidCapacityException(); | ||
| } | ||
|
|
||
| return await parkingLotsRepository.CreateParkingLot(parkingLotDto.ToEntity()); |
There was a problem hiding this comment.
well: hold transfer to entity logic in DTO
| public async Task<List<ParkingLot>> GetOnePageAsync(int pageIndex) | ||
| { | ||
| List<ParkingLot> allParkingLots = await parkingLotsRepository.GetAllParkingLots(); | ||
| int pageSize = 15; |
There was a problem hiding this comment.
suggestion: extract this variable to a constant
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.