homework-pengyu #6
Conversation
| await _parkingLotsService.DeleteAsync(name); | ||
| return NoContent(); | ||
| } | ||
|
|
There was a problem hiding this comment.
suggest move code logic to service layer
| return NoContent(); | ||
| } | ||
|
|
||
| [HttpGet] |
| using Microsoft.AspNetCore.Mvc.Filters; | ||
| using ParkingLotApi.Exceptions; | ||
|
|
||
| namespace ParkingLotApi.Filters |
There was a problem hiding this comment.
suggest add some exceptions such as pageIndexInvalidException
| } | ||
|
|
||
| [HttpGet] | ||
| public async Task<ActionResult<ParkingLotDto>> Get(int? pageSize, int? pageIndex) |
There was a problem hiding this comment.
suggest method name is ***Async in controller
|
|
||
| namespace ParkingLotApi.Services | ||
| { | ||
| public interface IParkingLotsService |
There was a problem hiding this comment.
suggestion: this interface can be removed, since there is only one class derived from it.
| } | ||
|
|
||
| [HttpGet] | ||
| public async Task<ActionResult<ParkingLotDto>> Get(int? pageSize, int? pageIndex) |
There was a problem hiding this comment.
suggestion: use int instead of int?, since there is no requirement to get all data
| @@ -1,6 +1,6 @@ | |||
| using Microsoft.AspNetCore.Mvc; | |||
|
|
|||
| namespace ParkingLotApi.Controllers | |||
| namespace ParkingLotApi.Dtos | |||
There was a problem hiding this comment.
suggestion: namespace should be ParkingLotApi.Controllers, since it's a Controller
| await parkingLotsRepository.DeleteParkingLot(parkingLotName); | ||
| } | ||
|
|
||
| public async Task<List<ParkingLot>> GetPage(int pageSize, int pageIndex) |
There was a problem hiding this comment.
suggestion: pageSize 15 should be saved in service, since it's a requirement
No description provided.