kailin counter-group #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
November 9, 2023 16:20
|
Good points:
|
falconwoo
reviewed
Nov 10, 2023
| expect(component.counters.length).toEqual(4) | ||
| }); | ||
|
|
||
| it('should remove counters when call OnResetCounters', () => { |
There was a problem hiding this comment.
suggestion: test description is misleading, what we test here is the remove feature
| @@ -0,0 +1,11 @@ | |||
| <button (click)="OnAdd()">add counter</button> | |||
There was a problem hiding this comment.
suggestion: missing title "Counter Group", it should be on top of the "add counter" button
| {num: 3} | ||
| ] | ||
| component.removeCounter(1) | ||
| expect(component.counters.length).toEqual(2) |
There was a problem hiding this comment.
well: nice to verify counters when test remove feature
| this.counters.push({num: 0}) | ||
| } | ||
|
|
||
| OnResetCounters() { |
There was a problem hiding this comment.
suggestion: this method should also be covered by test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.