CounterStuffByWangJing #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slb-bgc-wk
reviewed
Nov 10, 2023
| {num: 3} | ||
| ] | ||
|
|
||
| get sum(){ |
There was a problem hiding this comment.
WangKe:
The Sum() method also need to be tested
|
WangKe: Suggestions:
|
falconwoo
reviewed
Nov 10, 2023
| @@ -0,0 +1,11 @@ | |||
| <button (click)="onAdd()">Add counter</button> | |||
There was a problem hiding this comment.
suggestion: add "Counter Group" title on top of "Add counter" button
|
|
||
| <div *ngFor="let counter of counters; index as i;"> | ||
| <app-counter [number]="counter.num" (change)="counter.num = $event"> </app-counter> | ||
| <button (click)="onDelete(i)">Delete</button> |
There was a problem hiding this comment.
suggestion: rename this button to Remove instead of Delete, to keep the same name with requirement.
| it('should remove a counter when call onDelete', ()=>{ | ||
| component.counters = [{num:1},{num:0}] | ||
| component.onDelete(0) | ||
| expect(component.counters).toEqual([{num:0}]) |
There was a problem hiding this comment.
well: verify counters when test remove feature
| component.onResetAll() | ||
| component.counters.forEach(element => | ||
| expect(element.num).toEqual(0)) | ||
| expect(component.sum).toEqual(0) |
There was a problem hiding this comment.
suggestion: verify for sum should be in another test, this test for reset feature only need verify counters change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.