Shuhan #3
Open
Shuhan #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parent) component to counter(child) component
…corresponding test
celianiu
reviewed
Nov 10, 2023
| <!-- <app-counter *ngFor="let counter of counters, index as i" [number]="counter.num" (change)="counter.num = $event"> | ||
| </app-counter> | ||
| <button (click)="removeCounter(i)" >Remove</button> --> | ||
| <div class="counter-format" *ngFor="let counter of counters; let i = index"> |
There was a problem hiding this comment.
Good: remove counter from group instead of passing the id to counter! 👍
|
Good：
|
falconwoo
reviewed
Nov 10, 2023
| @@ -0,0 +1,11 @@ | |||
| <button (click)="onAdd()">Add counter</button> | |||
| <!-- <app-counter *ngFor="let counter of counters, index as i" [number]="counter.num" (change)="counter.num = $event"> | |||
| const incrementValue=3 | ||
| component.counters[0].num += incrementValue | ||
|
|
||
| expect(component.sum).toEqual(initialSum+incrementValue) |
There was a problem hiding this comment.
suggestion: initialSum+incrementValue can be extracted as a const named expected
| it('should reset numbers in counters to 0 when call resetSum', () => { | ||
| component.reset() | ||
| const resetSum = component.sum | ||
| expect(resetSum).toBe(0) |
There was a problem hiding this comment.
suggestion: no need to verify Sum here, since we already cover the logic in another test
| const resetSum = component.sum | ||
| expect(resetSum).toBe(0) | ||
|
|
||
| component.counters.forEach(counter => { |
There was a problem hiding this comment.
well: nice to verify counters when test reset.
| }) | ||
|
|
||
| it('should reset numbers in counters to 0 when call resetSum', () => { | ||
| component.reset() |
There was a problem hiding this comment.
suggestion: we also need give init data for counters, to see the value change, like
components.counters = {
{num: 1},
{num: 2}
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.