WangKe's HW #5
Open
WangKe's HW #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lklgithub
reviewed
Nov 10, 2023
lklgithub
left a comment
lklgithub
left a comment
There was a problem hiding this comment.
well
good code logic
comprehensive test coverage
need to better
add some test type message commit
| @@ -0,0 +1,19 @@ | |||
| <div> | |||
| <counter | |||
There was a problem hiding this comment.
good code style of writing such as define remove and reset event to receive counter id
lklgithub
reviewed
Nov 10, 2023
| expect(component.counters[0].num).toEqual(0); | ||
| expect(component.counters[1].num).toEqual(0); | ||
| }) | ||
|
|
There was a problem hiding this comment.
suggest add remove test(give counters[2], to call RemoveCounterWithIndex())
falconwoo
reviewed
Nov 10, 2023
| component.onReset(); | ||
|
|
||
| expect(component.counters[0].num).toEqual(0); | ||
| expect(component.counters[1].num).toEqual(0); |
There was a problem hiding this comment.
well: nice to verify counters when test reset
| describe('CounterComponent', () => { | ||
| let component: CounterComponent; | ||
| let fixture: ComponentFixture<CounterComponent>; | ||
| //let groupComponent : CounterGroupComponent; |
| expect(component.number).toEqual(1); | ||
| }) | ||
|
|
||
| it('should be deleted when click the remove button', () => { |
There was a problem hiding this comment.
suggestion: this test is failed, we can try to move this feature to counter group
| @@ -0,0 +1,10 @@ | |||
| <div style="margin: 1px;"> | |||
| <button (click)="onIncreaseNumber()" class="btn btn-primary">Plus</button> | |||
There was a problem hiding this comment.
suggestion: maybe it's better to use + as button text, since it's more general
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.