20231108 ParkingLot Apis implemented #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
November 8, 2023 13:04
JCLTW
reviewed
Nov 8, 2023
| var mongoDB = client.GetDatabase(dbOptions.Value.DatabaseName); | ||
| collection = mongoDB.GetCollection<ParkingLotDto>(dbOptions.Value.CollectionName); | ||
| } | ||
| public async Task<ParkingLotDto> AddOneAsync(ParkingLotDto parkingLotDto) |
| { | ||
| if (pageIndex < 1) | ||
| { | ||
| throw new InvalidCapacityException(); |
There was a problem hiding this comment.
Page size 小于1的需求需要澄清，另外异常类型此处为什么需要跑出InvaliCapaciy
| return await _parkingLotRepository.GetAllAsync(); | ||
| } | ||
|
|
||
| public async Task<List<ParkingLotDto>> GetByPageIndexAsync(int pageIndex ,int pageSize = 15) |
| throw new InvalidCapacityException(); | ||
| } | ||
| var res = await GetAllAsync(); | ||
| return res.Skip((pageIndex-1) * pageSize).Take(pageSize).ToList(); |
|
|
||
| private async Task ValidateCapacityAndName(int capacity, string name) | ||
| { | ||
| if (capacity < 10) |
| { | ||
| if (!ObjectId.TryParse(id, out _)) | ||
| { | ||
| throw new InvalidParkingLotNameOrIdException(); |
| @@ -0,0 +1,71 @@ | |||
| # For more info on HTTP files go to https://aka.ms/vs/httpfile | |||
| public class WeatherForecastControllerTest : TestBase | ||
| { | ||
|
|
||
| public WeatherForecastControllerTest(WebApplicationFactory<Program> factory) : base(factory) |
| protected HttpClient GetClient() | ||
| { | ||
| return Factory.CreateClient(); | ||
| //return Factory.WithWebHostBuilder(builder => |
XinwenXiang
reviewed
Nov 9, 2023
ParkingLotApi/DTOs/ParkingLotDto.cs
Outdated
|
|
||
| namespace ParkingLotApi.DTOs | ||
| { | ||
| public class ParkingLotDto |
| @@ -0,0 +1,13 @@ | |||
| namespace ParkingLotApi.DTOs | |||
| { | |||
| public class ParkingLotDtoRequest | |||
| { | ||
| public class IdNotExistExceptionFilter : IActionFilter, IOrderedFilter | ||
| { | ||
| public int Order => int.MaxValue - 10; |
There was a problem hiding this comment.
Actually, IOrderedFilter define exception throw order, you can adjust it according situation.
| } | ||
| public async Task<ParkingLotDto> AddOneAsync(ParkingLotDto parkingLotDto) | ||
| { | ||
| if (parkingLotDto.Id == null || !ObjectId.TryParse(parkingLotDto.Id, out var _)) |
|
Well:
May can do better:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.