homework #2
Open
homework #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JCLTW
reviewed
Nov 8, 2023
| } | ||
|
|
||
| [HttpGet] | ||
| public async Task<ActionResult<List<ParkingLot>>> GetAllAsync(int? pageIndex, int? pageSize = 15) |
There was a problem hiding this comment.
pageSize 暂时没有需要更新的需求，可以定义为常量，不暴露给客户，允许其修改
| } | ||
| public async Task<ParkingLot> CreateAsync( ParkingLotDto parkingLotDto) | ||
| { | ||
| if (parkingLotDto.Capacity < 10) throw new InvaildCapacityException(); |
| { | ||
| var skip = (pageIndex - 1) * pageSize; | ||
| var query = _parkingLotCollection.Find(a => true); | ||
| var parkinglots = await query.Skip(skip).Limit(pageSize).ToListAsync(); |
dianjing104
reviewed
Nov 9, 2023
| } | ||
|
|
||
| [HttpPut("{id}")] | ||
| public async Task<ActionResult> UpdateAsync(string id, [FromBody] ParkingLotDto parkingLotDto) |
There was a problem hiding this comment.
Probably you could define a new DTO with capacity only since we only modify capacity.
|
|
||
| internal async Task<ParkingLot> UpdateAsync(string id, ParkingLotDto parkingLotDto) | ||
| { | ||
| return await _parkingLotRepository.Update(id, parkingLotDto.ToModel()); |
There was a problem hiding this comment.
Probably could check capacity is less than 10
|
Well:
Less well:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.