Homework from Xinwei Lu #4
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 13 commits
November 8, 2023 13:10
JCLTW
reviewed
Nov 8, 2023
| [HttpPut("{id}")] | ||
| public async Task<ActionResult> UpdateCapacityAsync(string id, CapacityDto capacityDto) | ||
| { | ||
| if (capacityDto.Capacity < 10) |
|
|
||
| public int Capacity { get; set; } | ||
|
|
||
| internal ParkingLot ToEntity() |
|
|
||
| namespace ParkingLotApi.Repositories; | ||
|
|
||
| public interface IParkingLotsRepository |
|
|
||
| public class ParkingLotsRepository : IParkingLotsRepository | ||
| { | ||
| private const int PageSize = 15; |
|
|
||
| public async Task<List<ParkingLot>> GetParkingLotsAsync(int pageNumber) | ||
| { | ||
| return await _parkingLotColelction.Find(_ => true).Skip((pageNumber - 1) * PageSize).Limit(PageSize).ToListAsync(); |
|
|
||
| public async Task<ParkingLot> AddParkingLotAsyncAsync(ParkingLotsDto parkingLotDto) | ||
| { | ||
| if (parkingLotDto.Capacity < 10) |
|
|
||
| namespace ParkingLotApiTest.Controller; | ||
|
|
||
| public class WeatherForecastControllerTest :TestBase |
LucasCyw
reviewed
Nov 9, 2023
| this._parkingLotsRepository = parkingLotsRepository; | ||
| } | ||
|
|
||
| public async Task<ParkingLot> AddParkingLotAsyncAsync(ParkingLotsDto parkingLotDto) |
There was a problem hiding this comment.
the name field is unique, need to check
LucasCyw
reviewed
Nov 9, 2023
| throw new ParkingLotNotFoundException(); | ||
| } | ||
|
|
||
| return _parkingLotColelction.Find(lot => lot.Id.Equals(id)).FirstOrDefault(); |
There was a problem hiding this comment.
maybe Find(lot => lot.Id.Equals(id)) can change to .Find(filter)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.