[TASK] Deprecate childNodes property for ViewHelpers #1091
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Associated TYPO3 Core patch: https://review.typo3.org/c/Packages/TYPO3.CMS/+/89571 |
lolli42
approved these changes
May 28, 2025
Currently, the raw parser nodes are provided twice to each ViewHelper instance: Once with `setViewHelperNode()` and once with `setChildNodes()`. The latter is now deprecated, together with the property `$childNodes`, since it can easily be subsituted like this within a ViewHelper: before: ```php $this->childNodes ``` after: ```php $this->viewHelperNode->getChildNodes() ```
s2b
force-pushed
the
task/deprecateChildNodes
branch
from
3d28cec to
c7c1cb7
Compare
lolli42
approved these changes
May 28, 2025
reviewtypo3org
pushed a commit
to TYPO3/typo3
that referenced
this pull request
May 28, 2025
`AbstractViewHelper::$childNodes` is deprecated and will be removed with Fluid v5. Original change in Fluid: TYPO3/Fluid#1091 Resolves: #106792 Releases: main, 13.4 Change-Id: I9aec7b161f287ecbafe461b327141bb8083d1ee4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/89571 Reviewed-by: Simon Praetorius <[email protected]> Reviewed-by: Christian Kuhn <[email protected]> Tested-by: Stefan Bürk <[email protected]> Tested-by: core-ci <[email protected]> Reviewed-by: Stefan Bürk <[email protected]> Tested-by: Simon Praetorius <[email protected]> Tested-by: Christian Kuhn <[email protected]>
reviewtypo3org
pushed a commit
to TYPO3/typo3
that referenced
this pull request
May 28, 2025
`AbstractViewHelper::$childNodes` is deprecated and will be removed with Fluid v5. Original change in Fluid: TYPO3/Fluid#1091 Resolves: #106792 Releases: main, 13.4 Change-Id: I9aec7b161f287ecbafe461b327141bb8083d1ee4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/89586 Tested-by: core-ci <[email protected]> Tested-by: Simon Praetorius <[email protected]> Reviewed-by: Simon Praetorius <[email protected]>
TYPO3IncTeam
pushed a commit
to TYPO3-CMS/fluid
that referenced
this pull request
May 28, 2025
`AbstractViewHelper::$childNodes` is deprecated and will be removed with Fluid v5. Original change in Fluid: TYPO3/Fluid#1091 Resolves: #106792 Releases: main, 13.4 Change-Id: I9aec7b161f287ecbafe461b327141bb8083d1ee4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/89571 Reviewed-by: Simon Praetorius <[email protected]> Reviewed-by: Christian Kuhn <[email protected]> Tested-by: Stefan Bürk <[email protected]> Tested-by: core-ci <[email protected]> Reviewed-by: Stefan Bürk <[email protected]> Tested-by: Simon Praetorius <[email protected]> Tested-by: Christian Kuhn <[email protected]>
TYPO3IncTeam
pushed a commit
to TYPO3-CMS/fluid
that referenced
this pull request
May 28, 2025
`AbstractViewHelper::$childNodes` is deprecated and will be removed with Fluid v5. Original change in Fluid: TYPO3/Fluid#1091 Resolves: #106792 Releases: main, 13.4 Change-Id: I9aec7b161f287ecbafe461b327141bb8083d1ee4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/89586 Tested-by: core-ci <[email protected]> Tested-by: Simon Praetorius <[email protected]> Reviewed-by: Simon Praetorius <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the raw parser nodes are provided twice to each
ViewHelper instance: Once with
setViewHelperNode()andonce with
setChildNodes(). The latter is now deprecated,together with the property
$childNodes, since it can easilybe subsituted like this within a ViewHelper:
before:
after: