refactor(datagrid): Phase 3 keyboard interaction cleanup#952
Merged
refactor(datagrid): Phase 3 keyboard interaction cleanup#952
Conversation
…andles arrow nav natively
…o Delete/Return reach overrides
…end of multi-row selection
… arrow nav skips hidden columns + Backspace-only row delete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DataGrid Phase 3 — full keyboard interaction refactor. Removes shadow handlers and custom reimplementations of NSTableView built-ins.
Key changes:
Net delta: -250 lines
Why
Audit re-evaluated. Most Phase 3 audit issues found to be already correct in current code (Phase 1/2 era fixes). Real Phase 3 changes:
Already correct (no changes): #6, #10, #11, #13, #14, #16, #23, #32, #33, #35.
See
docs/development/datagrid-audit.mdPhase 3 Status section.Behaviors preserved
Test plan