chore: clean up dead code from #956 refactor#961
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Post-merge cleanup of dead code left behind by the #956 query execution refactor (PR #960).
executePaginatedTaggedQuery,fetchMoreScanItems,fetchMoreQueryItems) plus the privatePaginationStatestruct and continuation-token cache that supported them. Simplifies one consumer block ingenerateStatementsfrom a 14-line cache lookup to a one-liner.%@ of %@%@ rows,%lld-%lld of %@ rows,%lld-%lld of %@%@ rows,%@ rows (more available),Load More,Enforce query result limit,Limit initial query results and load more on demand,Query results exceeding this limit show Load More / Fetch All buttons.Net: 451 lines deleted, no behavior change.
Out of scope (intentional)
Packages/TableProCore/Sources/TableProPluginKit/(iOS package mirror) still has the old paged API. Not linked into the macOS app, only intoTableProMobile.xcodeproj. Migrating the iOS PluginKit is iOS-team work; the two PluginKits will need to be unified later.Test plan
Pure code deletion, no behavior change. Verify by build:
xcodebuild -project TablePro.xcodeproj -scheme TablePro -configuration Debug build -skipPackagePluginValidationpassesfetchScanItems/fetchQueryItems)Verification grep
Should return zero hits in
TablePro/,Plugins/, andTableProTests/: