fix: call ripgrep with explicit utf-8 encoding.#1199
Merged
CyanVoxel merged 1 commit intoTagStudioDev:mainfrom Jan 23, 2026
Merged
fix: call ripgrep with explicit utf-8 encoding.#1199CyanVoxel merged 1 commit intoTagStudioDev:mainfrom
CyanVoxel merged 1 commit intoTagStudioDev:mainfrom
Conversation
Computerdores
approved these changes
Nov 12, 2025
Collaborator
Computerdores
left a comment
There was a problem hiding this comment.
Code looks good, also very nice that you wrote a regression test
8 tasks
Member
|
Sorry for the delay on pulling this, and thank you so much for your work on this fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Call ripgrep with explicit
UTF-8encoding to prevent issues with multi-byte characters.When calling
subprocess.Popen, (which is wheresilent_subprocess::silent_runeventually ends up) withtext=Truewithout specifying the encoding, python will use the encoding returned bylocale::getencoding.On Linux this returns


UTF-8while on Windows it will returncp1252which causes issues with multi-byte characters like em dashes or Japanese characters.Fixes #1195.
Before
I've omitted
こんにちは.txtfrom the screenshot since it hangs the program with the error reported in #1195After
Tasks Completed