-
-
Notifications
You must be signed in to change notification settings - Fork 424
refactor: thumbnail renderers #1217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
TrigamDev
wants to merge
20
commits into
TagStudioDev:main
Choose a base branch
from
TrigamDev:refactor/thumbnail-renderers
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
refactor: thumbnail renderers #1217
TrigamDev
wants to merge
20
commits into
TagStudioDev:main
from
TrigamDev:refactor/thumbnail-renderers
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
src/tagstudio/qt/previews/renderer.py, moving them into their own files insrc/tagstudio/qt/previews/renderers/*_renderer.py.RendererContextobject, which provides the file path, file extension, image size, pixel ratio, and whether the image is being used for a grid thumbnail..tarand.7zipfile wrappers have been split out fromsrc/tagstudio/qt/previews/renderer.py, moving them into their own files insrc/tagstudio/qt/helpers/file_wrappers/archive/*_file.py..zipand.rarfiles. This is because:renderer.pywould result in a circular dependency, plus checking againsttype[ArchiveFile]is nicer..exrfiles are now handled better.OpenEXR.OpenEXRis also now used to get their width and height..zipfiles including their name in their file paths.Notes
I wasn't sure what to do with the following files, so I just left them where they were.
src/tagstudio/qt/previews/vendored/ffmpeg.pysrc/tagstudio/qt/previews/vendored/pydub/audio_segment.pysrc/tagstudio/qt/previews/vendored/pydub/utils.pyTasks Completed