fix: 'Add Tag to Selected' action fails

[TrigamDev]

Summary

Fixes a bug where using the 'Edit > Add Tag to Selected' action would fail and not add the chosen tag.

Was brought up in https://discord.com/channels/1229183630228848661/1229309667528806420/1442232941509083197.

(Recreated from #1223 as it was closed when I renamed the branch)

Tasks Completed

• Platforms Tested:
  • Windows x86
  • Windows ARM
  • macOS x86
  • macOS ARM
  • Linux x86
  • Linux ARM
• Tested For:
  • Basic functionality
  • PyInstaller executable

[Computerdores]

lgtm

[CyanVoxel]

Thank you for the quick fix! Though I believe this uncovered a related issue where setting the tags from this action causes the selection in the preview panel to reset. Good news is that it looks straightforward enough to fix, with the cause seeming to be the lambda variable assignment on line 371 of ts_qt.py. Here I've removed the variable s that was being set with the initial empty value and am instead using the the direct self.selected value which uses the correct selection value when the lambda is called:

self.add_tag_modal.tsp.tag_chosen.connect(
            lambda t: (
                self.add_tags_to_selected_callback([t]),
                self.main_window.preview_panel.set_selection(self.selected),
            )
        )

I also noticed a similar use of s=self.selected in the lambda above this one, though haven't looked into the repercussions of that one...

[TrigamDev]

I've also noticed while testing just now that, when adding tags through the 'Add Tag' button, the badges associated with that tag will update as expected. But when doing the same with the 'Add Tag to Selected' action, the badges will only update upon viewing the entry in the preview panel.

[TrigamDev]

I've also noticed while testing just now that, when adding tags through the 'Add Tag' button, the badges associated with that tag will update as expected. But when doing the same with the 'Add Tag to Selected' action, the badges will only update upon viewing the entry in the preview panel.

Went ahead and fixed this as well

[CyanVoxel]

Looks all good, thank you for the fixes!