Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add 3d object rendering using open3d #693

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

JonatanNevo
Copy link

@JonatanNevo JonatanNevo commented Jan 8, 2025

Implementation for issue #351

This is a WIP, I cannot get open3d to behave nicely with multithreading so I am rendering each image one at a time and it takes a while.

If anyone has any suggestions I would love to hear it

@JonatanNevo JonatanNevo marked this pull request as draft January 8, 2025 20:30
@JonatanNevo JonatanNevo changed the title WIP: Add 3d object rendering using open3d feat: Add 3d object rendering using open3d Jan 8, 2025
@CyanVoxel CyanVoxel added Type: Enhancement New feature or request Type: QoL A quality of life (QoL) enhancement or suggestion Type: UI/UX User interface and/or user experience Priority: Medium An issue that shouldn't be be saved for last Status: Help Wanted Extra attention is needed labels Jan 9, 2025
@CyanVoxel
Copy link
Member

I'm afraid that this appears to almost instantly segfault for me, so I'm unable to test or help out with this implementation as it is...
The new core imports also need to be prepended by src., so they'll look something like "from src.core.utils.singleton import Singleton" - this was something I needed to do in order for the program to even start.

Also related, but there's a new thumbnail cacher being added in #694 which also touches the renderer codebase quite a bit, which should at least alleviate some of what you were trying to do here.

@JonatanNevo
Copy link
Author

I'm afraid that this appears to almost instantly segfault for me, so I'm unable to test or help out with this implementation as it is... The new core imports also need to be prepended by src., so they'll look something like "from src.core.utils.singleton import Singleton" - this was something I needed to do in order for the program to even start.

Also related, but there's a new thumbnail cacher being added in #694 which also touches the renderer codebase quite a bit, which should at least alleviate some of what you were trying to do here.

Yeah I will wait for the caching mechanism and then continue working on this, this is why I put this as a draft

@Lunarient
Copy link

In case anyone else runs into problems with this on wayland, it only works if you have the env variable
XDG_SESSION_TYPE=x11
It looks like it's a bigger problem with open3d as far as I can tell.

@xarvex
Copy link
Member

xarvex commented Mar 12, 2025

Hi! What's the current status; is this still being worked on?

@Lunarient
Copy link

Hi! What's the current status; is this still being worked on?

Hi! Ive been working on this off and on. I currently have it working with a final bug of the render thread not shutting down properly on program exit. I'm hoping to have it done within the next few days but I welcome any help.

@xarvex
Copy link
Member

xarvex commented Mar 12, 2025

Hi! What's the current status; is this still being worked on?

Hi! Ive been working on this off and on. I currently have it working with a final bug of the render thread not shutting down properly on program exit. I'm hoping to have it done within the next few days but I welcome any help.

That's great to hear! If you want, what you could do to get some help and eyes on it is create a new PR (you can make a draft like here), and state in the description that it supersedes this one. That should tell people that it exists and is needing attention.

@Lunarient
Copy link

Hi! What's the current status; is this still being worked on?

Hi! Ive been working on this off and on. I currently have it working with a final bug of the render thread not shutting down properly on program exit. I'm hoping to have it done within the next few days but I welcome any help.

That's great to hear! If you want, what you could do to get some help and eyes on it is create a new PR (you can make a draft like here), and state in the description that it supersedes this one. That should tell people that it exists and is needing attention.

Okay! I wasn't sure what the github etiquette for situations like this was. I'll do that later tonight, thank you.

@JonatanNevo
Copy link
Author

Hi! What's the current status; is this still being worked on?

Hi! Ive been working on this off and on. I currently have it working with a final bug of the render thread not shutting down properly on program exit. I'm hoping to have it done within the next few days but I welcome any help.

That's great to hear! If you want, what you could do to get some help and eyes on it is create a new PR (you can make a draft like here), and state in the description that it supersedes this one. That should tell people that it exists and is needing attention.

Okay! I wasn't sure what the github etiquette for situations like this was. I'll do that later tonight, thank you.

If you want I can close this PR after you'll open the new one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Medium An issue that shouldn't be be saved for last Status: Help Wanted Extra attention is needed Type: Enhancement New feature or request Type: QoL A quality of life (QoL) enhancement or suggestion Type: UI/UX User interface and/or user experience
Projects
Status: 🚧 In progress
Development

Successfully merging this pull request may close these issues.

4 participants