feat: start storing date_created and date_modified #745
+47
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CyanVoxel
added
Type: Enhancement
|
Hey, is this still something you're interested in and able to work on? If not that's okay, it's just something that we'd like to get in the program soon and there are some others interested in working on this if you're unable to |
|
Hey Cyan, apologies for the delay I've had a lot of issues with git recently, this pull request doesn't even show up on my fork. Finally fixed it so i can commit and push the changes soon. Just an update on where I'm at, refresh_dir now populates the library with date_created and date_modified values, sort options for both are usable. |
feat: implement sorting by creation and modification date fix: resolve git merge conflicts and push issues fix: correct typos in comments and code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds population of date_created and date_modified for entries and updates date_modified on refresh_dir. Updating date_created was skipped since file replacement or recreation is rare and can be treated as modification.
Note: This does not include sorting, only attribute implementation.