Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: recent libraries list improvements #881

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

CyanVoxel
Copy link
Member

Summary

This PR makes a couple tweaks to the Recent Libraries menu item:

  1. Add a more specific error message when trying to open a library location that no longer exists (while keeping in mind that the full library path may not always be shown anymore, and in the future library files may not be in the same location as the folders they use)
  2. Increase the recent library list limit from 5 to 10

image

Tasks Completed

  • Platforms Tested:
    • Windows x86
    • Windows ARM
    • macOS x86
    • macOS ARM
    • Linux x86
    • Linux ARM
  • Tested For:
    • Basic functionality
    • PyInstaller executable

@CyanVoxel CyanVoxel added Type: QoL A quality of life (QoL) enhancement or suggestion Type: UI/UX User interface and/or user experience Priority: Low Doesn't require immediate attention Status: Review Needed A review of this is needed labels Mar 21, 2025
@CyanVoxel CyanVoxel added this to the Alpha v9.5.2 milestone Mar 21, 2025
@kitsumed
Copy link
Contributor

kitsumed commented Mar 21, 2025

I think this pull will also close : #810.
But I'm not sure 100% as the error message was saying access denied but this might be related to be file not beeing found / readable.

@CyanVoxel
Copy link
Member Author

I think this pull will also close : #810. But I'm not sure 100%.

#810 seems unrelated as it's a different error in a different part of the codebase

@Computerdores
Copy link
Collaborator

Wouldn't it be better if it always showed the full path in the "Library Not Found" message? After all, knowing that a directory called "XYZ" wasn't found somewhere on the drive isn't all that useful (and not everyone is on top of their file organisation enough to immediately know where they had the library)

@CyanVoxel
Copy link
Member Author

Wouldn't it be better if it always showed the full path in the "Library Not Found" message? After all, knowing that a directory called "XYZ" wasn't found somewhere on the drive isn't all that useful (and not everyone is on top of their file organisation enough to immediately know where they had the library)

I think it would, however with the setting introduced in #841 this may be considered a privacy concern for those who don't want their full file paths displayed on screen anywhere. Maybe that's just me reading into it too much though. After all, the About screen still shows the full config path location.

Copy link
Collaborator

@Computerdores Computerdores left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides me uncovering an unrelated bug (#889) while testing, this seems work perfectly!
(I still think that it would be good to have a setting in the future whether to show the full path in the popup, but this seems good as is)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Low Doesn't require immediate attention Status: Review Needed A review of this is needed Type: QoL A quality of life (QoL) enhancement or suggestion Type: UI/UX User interface and/or user experience
Projects
Status: 🍃 Pending Merge
Development

Successfully merging this pull request may close these issues.

3 participants