Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove unescaped ampersand from "about.description" #885

Merged
merged 1 commit into from
Mar 25, 2025

Conversation

CyanVoxel
Copy link
Member

Summary

Remove an unescaped ampersand from the "about.description" translation key which caused the text to render incorrectly. This could have been addressed by escaping the ampersand (e.g. "&&") but I've opted to replace it with the word "and" instead.

Before:
image
After:
image

Tasks Completed

  • Platforms Tested:
    • Windows x86
    • Windows ARM
    • macOS x86
    • macOS ARM
    • Linux x86
    • Linux ARM
  • Tested For:
    • Basic functionality
    • PyInstaller executable

@CyanVoxel CyanVoxel added Type: Bug Something isn't working as intended Type: Translation Translates or improves translation capabilities labels Mar 22, 2025
@CyanVoxel CyanVoxel added this to the Alpha v9.5.2 milestone Mar 22, 2025
Copy link
Collaborator

@Computerdores Computerdores left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sieht gut aus!

@CyanVoxel CyanVoxel merged commit a4e61f9 into main Mar 25, 2025
10 checks passed
@CyanVoxel CyanVoxel deleted the fix-about-ampersand branch March 25, 2025 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something isn't working as intended Type: Translation Translates or improves translation capabilities
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants